Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use normalized version of barcode for duplicate checks #738

Closed
bltravis opened this issue Mar 14, 2024 · 0 comments · Fixed by #758
Closed

Use normalized version of barcode for duplicate checks #738

bltravis opened this issue Mar 14, 2024 · 0 comments · Fixed by #758
Assignees
@bltravis

Comments

@bltravis
Copy link
Collaborator

FOLIO validates barcodes by applying a str.lower() function to the presented value. We should do the same when checking for duplicate barcodes.
@bltravis bltravis self-assigned this Mar 14, 2024
btravisebsco pushed a commit that referenced this issue Apr 9, 2024
@bltravis
Update item_mapper to perform case-insensitive comparisons to detect …
718357a 
…duplicate barcodes. Fixes Use normalized version of barcode for duplicate checks #738
@bltravis bltravis mentioned this issue Apr 9, 2024
Merged
@bltravis bltravis linked a pull request Apr 9, 2024 that will close this issue
Update item_mapper to perform case-insensitive duplicate barcode detection for items #758
Merged
bltravis added a commit that referenced this issue Apr 11, 2024
@bltravis
Update item_mapper to perform case-insensitive comparisons to detect …
64b97fd 
…duplicate barcodes. Fixes Use normalized version of barcode for duplicate checks #738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bltravis bltravis

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bltravis