Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

501 make the sv based mappers add default values from the schemas close #501 #607

Conversation

branchedelac
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #607 (748a0ca) into main (ef85063) will decrease coverage by 0.03%.
The diff coverage is 97.59%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   69.89%   69.87%   -0.03%     
==========================================
  Files          97       97              
  Lines       10458    10453       -5     
  Branches     1245     1247       +2     
==========================================
- Hits         7310     7304       -6     
  Misses       2864     2864              
- Partials      284      285       +1     
Flag Coverage Δ
unittests 69.87% <97.59%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ng_file_transformation/mapping_file_mapper_base.py 83.24% <85.71%> (-0.18%) ⬇️
...ools/mapping_file_transformation/courses_mapper.py 80.76% <100.00%> (ø)
...ols/mapping_file_transformation/holdings_mapper.py 76.71% <100.00%> (ø)
...n_tools/mapping_file_transformation/item_mapper.py 45.76% <100.00%> (ø)
..._tools/mapping_file_transformation/order_mapper.py 85.62% <100.00%> (ø)
...mapping_file_transformation/organization_mapper.py 80.14% <100.00%> (ø)
...n_tools/mapping_file_transformation/user_mapper.py 76.76% <100.00%> (ø)
src/folio_migration_tools/report_blurbs.py 100.00% <100.00%> (ø)
tests/test_holdings_mapper.py 100.00% <100.00%> (ø)
tests/test_mapping_file_mapper_base.py 98.07% <100.00%> (+0.11%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -2832,6 +2836,95 @@ def test_map_enums_invalid_not_required_deeper_level(mocked_folio_client):
folio_rec, folio_id = mapper.do_map(record, record["id"], FOLIONamespaces.organizations)


def test_map_booleans(mocked_folio_client: FolioClient):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

@bltravis bltravis merged commit 5289c26 into main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the *SV-based mappers add default values from the schemas
3 participants