Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the *SV-based mappers add default values from the schemas #501

Closed
fontanka16 opened this issue Feb 10, 2023 · 1 comment · Fixed by #607
Closed

Make the *SV-based mappers add default values from the schemas #501

fontanka16 opened this issue Feb 10, 2023 · 1 comment · Fixed by #607

Comments

@fontanka16
Copy link
Contributor

No description provided.

@fontanka16
Copy link
Contributor Author

fontanka16 commented Mar 23, 2023

Proposal to fix this:

  • Add a parameter to the get_prop function, for the default value from the map.
  • Add a check in (the super().) get_prop that returns this value if no other value has been set.
  • In all the places of mapping_file_mapper_base where get_prop is called, add the default parameter or the empty string to the new parameter
  • Make sure all implementations of get_prop accepts the parameter
  • Remove existing handling for this outside of get_prop in mapping_file_mapper_base. It is handled in at least one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants