Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes for Paul's 24-fork pipeline #1874

Merged
merged 20 commits into from
Feb 16, 2023
Merged

🐛 Fixes for Paul's 24-fork pipeline #1874

merged 20 commits into from
Feb 16, 2023

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Jan 20, 2023

Description

  • Fixes some points where node names were being duplicated
  • Includes movement-parameters in linked inputs for template-space nuisance regression
  • Fixes bug where
    "motion-filter-info",
    "motion-filter-plot"]}
    were not getting labeled with filt-*[1]
  • Inserts an _ between the node name and subnode index in MapNodes
  • Caches to disk when using Nilearn to calculate connectome correlation matrices
  • Adds BIDS label MNI152NLin2009cAsym to /code/CPAC/resources/templates/mni_icbm152_t1_tal_nlin_asym_09c.nii (related: 🐛 mni_icbm152_t1_tal_nlin_asym_09c vs. tpl-MNI152NLin2009cAsym C-PAC_templates#18)
  • Drops space and res from atlas entities when combining name for timeseries & connectivity matrices

Technical details

  • [1]
    All non-standard file entities SHOULD conform to BIDS-style naming conventions, including alphabetic entities and suffixes and alphanumeric labels/indices.
    Common principles: Unspecified data Brain Imaging Data Structure v1.8.0
  • updates license notices on changed files

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy force-pushed the debug/many-forks branch 2 times, most recently from ebc5531 to 2ab869f Compare January 27, 2023 19:46
@shnizzedy shnizzedy changed the title 🚧 (WIP) 🐛 Fixes for Paul's pipeline 🐛 Fixes for Paul's 24-fork pipeline Jan 27, 2023
@shnizzedy shnizzedy force-pushed the debug/many-forks branch 4 times, most recently from 085ea54 to 9c36cd6 Compare February 3, 2023 17:12
@shnizzedy shnizzedy marked this pull request as ready for review February 7, 2023 21:13
@shnizzedy shnizzedy added this to the 1.8.5 release milestone Feb 10, 2023
@shnizzedy shnizzedy merged commit bb24fa2 into develop Feb 16, 2023
@shnizzedy shnizzedy deleted the debug/many-forks branch February 16, 2023 19:21
@shnizzedy shnizzedy mentioned this pull request Feb 24, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants