Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 mni_icbm152_t1_tal_nlin_asym_09c vs. tpl-MNI152NLin2009cAsym #18

Open
1 task
shnizzedy opened this issue Jan 27, 2023 · 1 comment
Open
1 task
Labels
bug Something isn't working user-reported

Comments

@shnizzedy
Copy link
Member

shnizzedy commented Jan 27, 2023

Describe the bug

Both of these templates (mni_icbm152_t1_tal_nlin_asym_09c.nii packaged in C-PAC & tpl-MNI152NLin2009cAsym from TemplateFlow) seem to be templates for space-MNI152NLin2009cAsym but they aren't identical.

Expected behavior

Templates are identical or have different names

Acceptance criteria

  • These two templates are differentiated

C-PAC version

v1.8.5-dev

Additional context

They both have b'mnc2nii mni_icbm152_nlin_asym_09c/mni_icbm152_t1_tal_nlin_asym_09c.mnc mni_icbm' as the description in the header, but mni_icbm152_t1_tal_nlin_asym_09c.nii has

cal_max         : 100.0
qoffset_x       : 0.0
qoffset_y       : 0.0
qoffset_z       : 0.0

where tpl-MNI152NLin2009cAsym_res-01_T1w.nii.gz from TemplateFlow has

cal_max         : 10000.0
qoffset_x       : -96.0
qoffset_y       : -132.0
qoffset_z       : -78.0

They look the same visually,

mni_icbm152_t1_tal_nlin_asym_09c tpl-MNI152NLin2009cAsym_res-01_T1w
mni_icbm152_t1_tal_nlin_asym_09c.png tpl-MNI152NLin2009cAsym_res-01_T1w.png

but get_fdata() shows roughly a 100× scaling between the data points (like the cal_max in the headers, although less precisely):

count	8530021.00
mean	101.04
std	7.21
min	-1844.27
25%	100.85
50%	100.92
75%	101.10
max	1029.66

histogram


Gist with files, headers, and images: https://gist.github.com/shnizzedy/03e8ba5ead9987b5a299e2501ec77ae0

@gkiar
Copy link
Contributor

gkiar commented Jan 30, 2023

Thanks for using the quickviz script to compare them! Super helpful to see that the correlation of the two is 1.0!

Can we track down a list of all nodes that use the mni_icbm152_t1_tal_nlin_asym_09c file by default? We should do a run that compares a complete pipeline with all of those nodes enabled (if possible), and then repeat it with the Templateflow-named version. I suspect we will see no difference, and then can just remove the old-named version.

@shnizzedy shnizzedy changed the title 🐛 mni_icbm152_t1_tal_nlin_asym_09c vs. tpl-MNI152NLin2009aAsym 🐛 mni_icbm152_t1_tal_nlin_asym_09c vs. tpl-MNI152NLin2009cAsym Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user-reported
Projects
Status: No status
Development

No branches or pull requests

2 participants