-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix multiple creds support for 'jwt' and 'key-auth' #899
Conversation
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 89.07% 89.08% +0.01%
==========================================
Files 136 136
Lines 3688 3692 +4
==========================================
+ Hits 3285 3289 +4
Misses 403 403
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
thanks a lot for taking care of this! The pull request looks good, I just dropped some comments here and there to enhance it a little bit.
Thanks!
Co-Authored-By: nakardo <diegonake@gmail.com>
Co-Authored-By: nakardo <diegonake@gmail.com>
Co-Authored-By: nakardo <diegonake@gmail.com>
Co-Authored-By: nakardo <diegonake@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now generally feels ok. I need to pull down your branch and make some smoke tests to make sure we do not screw up anything. Good job though, I think this is going to get merged really soon.
…ressGateway#856 fix multiple creds support for 'jwt' and 'key-auth' closes ExpressGateway#856
See: #856
Also introduces changes on the
credentials.test.js
tests to make sure other policies work as intended.