Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple creds support for 'jwt' and 'key-auth' #899

Merged
merged 7 commits into from
Apr 11, 2019

Conversation

nakardo
Copy link
Contributor

@nakardo nakardo commented Apr 5, 2019

See: #856

Also introduces changes on the credentials.test.js tests to make sure other policies work as intended.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #899 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   89.07%   89.08%   +0.01%     
==========================================
  Files         136      136              
  Lines        3688     3692       +4     
==========================================
+ Hits         3285     3289       +4     
  Misses        403      403
Impacted Files Coverage Δ
lib/services/credentials/credential.service.js 86.74% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b9a9e...5d10b0a. Read the comment docs.

Copy link
Member

@XVincentX XVincentX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

thanks a lot for taking care of this! The pull request looks good, I just dropped some comments here and there to enhance it a little bit.

Thanks!

lib/services/credentials/credential.service.js Outdated Show resolved Hide resolved
lib/services/credentials/credential.service.js Outdated Show resolved Hide resolved
lib/services/credentials/credential.service.js Outdated Show resolved Hide resolved
test/services/credential-service/credentials.test.js Outdated Show resolved Hide resolved
test/services/credential-service/credentials.test.js Outdated Show resolved Hide resolved
lib/services/credentials/credential.service.js Outdated Show resolved Hide resolved
XVincentX and others added 6 commits April 9, 2019 20:08
Co-Authored-By: nakardo <diegonake@gmail.com>
Co-Authored-By: nakardo <diegonake@gmail.com>
Co-Authored-By: nakardo <diegonake@gmail.com>
Co-Authored-By: nakardo <diegonake@gmail.com>
Copy link
Member

@XVincentX XVincentX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now generally feels ok. I need to pull down your branch and make some smoke tests to make sure we do not screw up anything. Good job though, I think this is going to get merged really soon.

@XVincentX XVincentX merged commit d1a9487 into ExpressGateway:master Apr 11, 2019
@nakardo nakardo deleted the fix-856 branch April 15, 2019 09:49
gatherchou pushed a commit to yilu-tech/express-gateway that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants