Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insertCredential fails when adding the second credential #856

Closed
devzsolt opened this issue Dec 20, 2018 · 1 comment
Closed

insertCredential fails when adding the second credential #856

devzsolt opened this issue Dec 20, 2018 · 1 comment

Comments

@devzsolt
Copy link

Credential service's insertCredential() calls getCredential() which fails to consider the scenario when a credential is not a single hash but a set of hashes in the DB.

First it causes a warning: WRONGTYPE Operation against a key holding the wrong kind of value
which is followed by the following error:

TypeError: Cannot read property 'properties' of undefined at processCredential (/path-to-project/node_modules/express-gateway/lib/services/credentials/credential.service.js:255:51) 
  at s.getCredential.credentialDao.getCredential.then.credential (/path-to-project/node_modules/express-gateway/lib/services/credentials/credential.service.js:138:14)

It's possible to reproduce always by creating a user with a credential and then deactivating the credential and creating a new one for the same user. Only key-auth and jwt type credentials are affected by the bug.
devzsolt pushed a commit to devzsolt/express-gateway that referenced this issue Dec 20, 2018
fix: avoid failure when inserting another credential for a user
5772998 
resolves ExpressGateway#856
insertCredential will call dao's getAllCredentials() which can handle
key-auth and jwt type credentials that were affected by the bug
some extra error handling were also added
@devzsolt devzsolt mentioned this issue Dec 20, 2018
Closed
@XVincentX
Copy link
Member

Thanks for the fix. I hope to be able to jump on this soon, I just didn't have the time.

XVincentX pushed a commit to devzsolt/express-gateway that referenced this issue Jan 3, 2019
@XVincentX
fix: avoid failure when inserting another credential for a user
210f480 
resolves ExpressGateway#856
insertCredential will call dao's getAllCredentials() which can handle
key-auth and jwt type credentials that were affected by the bug
some extra error handling were also added
@willfe willfe mentioned this issue Mar 28, 2019
Closed
nakardo added a commit to nakardo/express-gateway that referenced this issue Apr 5, 2019
@nakardo
fix multiple creds support for 'jwt' and 'key-auth'
de5b1ac 
See: ExpressGateway#856
@nakardo nakardo mentioned this issue Apr 5, 2019
Merged
gatherchou pushed a commit to yilu-tech/express-gateway that referenced this issue Jul 29, 2021
@nakardo
fix multiple creds support for 'jwt' and 'key-auth'
1935c6c 
See: ExpressGateway#856
gatherchou pushed a commit to yilu-tech/express-gateway that referenced this issue Jul 29, 2021
@XVincentX
Merge pull request ExpressGateway#899 from nakardo/fix-856 closes Exp…
4d720b4 
…ressGateway#856

fix multiple creds support for 'jwt' and 'key-auth' closes ExpressGateway#856
@qsays qsays mentioned this issue Dec 23, 2022
Open
@u8558574xuyou7438 u8558574xuyou7438 mentioned this issue Dec 23, 2022
Open
@qsays qsays mentioned this issue Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid failure when inserting another credential for a user devzsolt/express-gateway
2 participants
@XVincentX @devzsolt