Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Can strike-through pre code block. #586

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

Krishna2323
Copy link
Contributor

@Krishna2323 Krishna2323 commented Oct 11, 2023

Fixed Issues

$ Expensify/App#24281

Tests

  1. Open any report
  2. Paste ~```Code```~
  3. Observe the code block text doesn't gets strike through line and code block creates line break before start and after end

QA

  1. Open any report
  2. Paste ~```Code```~
  3. Observe the code block text doesn't gets strike through line and code block creates line break before start and after end

Demo

fix_demo.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
@Krishna2323 Krishna2323 requested a review from a team as a code owner October 11, 2023 13:54
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from neil-marcellini and removed request for a team October 11, 2023 13:54
@Krishna2323
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@neil-marcellini
Copy link
Contributor

@Krishna2323 I edited the "Fixed issues" link format for you which is important to make sure we get the proper person assigned. I'll assign @eVoloshchak from the issue for the C+ review and then Andrew will review after C+ approves.

@neil-marcellini
Copy link
Contributor

@eVoloshchak I can't assign you but would you please review?

@neil-marcellini neil-marcellini removed their request for review October 11, 2023 19:06
@Krishna2323
Copy link
Contributor Author

@eVoloshchak friendly reminder for a review.

@eVoloshchak
Copy link
Contributor

Looks good!
@Krishna2323, when submitting the second PR make sure that step 2 for Tests includes the correct message, it should be

Paste ~```Test```~

@Krishna2323
Copy link
Contributor Author

@arosiclair, sorry for bump but I think its needed here 😅

@arosiclair arosiclair merged commit bdbdf44 into Expensify:main Oct 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants