Merge pull request #586 from Krishna2323/krishna2323/issue/24281

fix: Can strike-through pre code block.
Expensify · Oct 13, 2023 · bdbdf44 · bdbdf44
2 parents 18bf903 + c7a1da9
commit bdbdf44
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/__tests__/ExpensiMark-HTML-test.js b/__tests__/ExpensiMark-HTML-test.js
@@ -447,6 +447,9 @@ test('Test code fencing with ExpensiMark syntax outside', () => {
 
     codeFenceExample = '_Test1 ```code``` Test2_';
     expect(parser.replace(codeFenceExample)).toBe('_Test1 <pre>code</pre> Test2_');
+
+    codeFenceExample = '~Test1 ```code``` Test2~';
+    expect(parser.replace(codeFenceExample)).toBe('~Test1 <pre>code</pre> Test2~');
 });
 
 test('Test code fencing with additional backticks inside', () => {

diff --git a/lib/ExpensiMark.js b/lib/ExpensiMark.js
@@ -216,7 +216,7 @@ export default class ExpensiMark {
             {
                 name: 'strikethrough',
                 regex: /\B~((?![\s~])[\s\S]*?[^\s~])~\B(?![^<]*(<\/pre>|<\/code>|<\/a>))/g,
-                replacement: (match, g1) => (this.containsNonPairTag(g1) ? match : `<del>${g1}</del>`),
+                replacement: (match, g1) => (g1.includes('<pre>') || this.containsNonPairTag(g1) ? match : `<del>${g1}</del>`),
             },
             {
                 name: 'newline',