-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating react-native-render-html version #6582
Conversation
Hi @chiragsalian the bold format looks good but for some reason the strikethrough format is not shown in new dot: |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @marcochavezf in version: 1.1.17-8 🚀
|
@chiragsalian PR https://github.com/Expensify/Web-Expensify/pull/32544 doesn't seem to be live. Is it ok to check off this or should we still QA? |
It just deployed. We are testing |
🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀
|
The only reason we just needed to update the react-native-render-html version is because,
they fixed rendering b tag in their recent version. It was always working with italics. And for strikethrough we were stripping it in the backend but this PR will allow it in future.
Details
Fixed Issues
$ #4899
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android