Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry pick PR #6479 to staging 🍒 #6481

Merged
merged 3 commits into from
Nov 25, 2021
Merged

🍒 Cherry pick PR #6479 to staging 🍒 #6481

merged 3 commits into from
Nov 25, 2021

Conversation

OSBotify
Copy link
Contributor

🍒 Cherry pick #6479 to staging 🍒

OSBotify and others added 2 commits November 25, 2021 19:21
@OSBotify
Merge pull request #6480 from Expensify/version-BUILD-dd291dcda088613…
9dcb5a9 
…3405de87573022edd6357818a

(cherry picked from commit d0d1d58)
@madmax330
Merge pull request #6479 from Expensify/cmartins-encodeURL
4aeec90 
Encode secondary login URL

(cherry picked from commit dd291dc)
@OSBotify OSBotify requested a review from a team as a code owner November 25, 2021 19:21
@MelvinBot MelvinBot removed the request for review from a team November 25, 2021 19:21
@OSBotify
Copy link
Contributor Author

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

@isagoico isagoico mentioned this pull request Nov 25, 2021
Merged
5 tasks
aldo-expensify
aldo-expensify approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@aldo-expensify aldo-expensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aldo-expensify aldo-expensify merged commit 1e2a041 into staging Nov 25, 2021
@aldo-expensify aldo-expensify deleted the OSBotify-cherry-pick-staging-6479 branch November 25, 2021 21:20
@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by @aldo-expensify in version: 1.1.16-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldo-expensify aldo-expensify aldo-expensify approved these changes

Assignees

@madmax330 madmax330

Labels
automerge Engineering Hourly KSv2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OSBotify @aldo-expensify @madmax330 @luacmartins