Encode secondary login URL

[luacmartins]

Details

iOS treats URL encoding a bit differently and I had to adjust it to be able to deeplink into the secondary login page in OldDot.

Fixed Issues

$ #6475

Tests

1. Launch the app and login with gmail account
2. Initiate VBA flow and add an "Open" bank account. Instructions.
3. At the last step tap "Add work email address"
4. Verify that OldDot opens in the accounts page and the add secondary login modal opens.

QA Steps

1. Launch the app and login with gmail account
2. Initiate VBA flow and add an "Open" bank account. Instructions.
3. At the last step tap "Add work email address"
4. Verify that OldDot opens in the accounts page and the add secondary login modal opens.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[isagoico]

@luacmartins hello! I think there were some conflicts while merging, we're not seeing build 1.1.16-9 #6481 (comment)

[luacmartins]

Thanks @isagoico! Conflicts resolved. Deploying here

[OSBotify]

🚀 Cherry-picked to staging by @madmax330 in version: 1.1.16-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[isagoico]

App is crashing on iOS and Android when tapping on "Add work email..." button. Video below

crash.mp4

[isagoico]

Tested this on Android and iOS and it's a pass 🎉 No more crashes!

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @madmax330 in version: 1.1.16-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[ogumen]

The accessibility issues related to this PR:

1. The "Add work email address" link is announced without role, just as plain text. The screen reader user is not informed that it opens a new browser tab - failure of WCAG SC 4.1.2
   
2. The grey Close button (#C6C9CA) on white background (#FFFFFF) has a color contrast ratio of 1.66:1, failing the minimum contrast requirements of 3.00:1 - failure of WCAG SC 1.4.11
3. The grey Email or Phone placeholder text (#7D8B8F) on white background (#FFFFFF) has a color contrast ratio of 3.52:1, failing the minimum color contrast of 4.50:1 - failure of WCAG SC 1.4.3
   
4. The white text (#FFFFFF) against green background (#03BB6D) has a color contrast ratio of 2.52:1, failing the minimum contrast requirements of 4.50:1 - failure of WCAG SC 1.4.3
   
5. The Close button and Privacy link have no visible outline on focus due to CSS outline:0 rule. The keyboard users will not be able to determine the currently focused element - failure of WCAG SC 2.4.7
   
6. The light green focus outline (#80E8BC) against green button (#03BB6D) has a color contrast ratio of 1.70:1, failing the minimum contrast requirements of 3.00:1 - failure of WCAG SC 1.4.11
   
7. The blue Privacy link (#0185FF) against white background (#FFFFFF) has a color contrast ratio of 3.62:1 failing the minimum color contrast requirements of 4.50:1 - failure of WCAG SC 1.4.3
   
8. The Close modal button is announced without any label, as "button" - failure of WCAG SC 4.1.2
   
9. Incorrect document role and no label provided for modal dialog - failure of WCAG SC 1.3.1
   
10. The Email or Phone text field uses placeholder text as the only label. Once user starts typing into the field, the placeholder text disappears and the field's purpose is no longer obvious - failure of WCAG SC 3.3.2
    
11. The focus is not trapped in the modal dialog and the background elements can be focused with keyboard - failure of WCAG SC 2.4.3

Secondary.login_Focus.not.trapped.in.modal.dialog.mp4

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅