Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send money disabled for restricted accounts #5851

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Send money disabled for restricted accounts #5851

merged 1 commit into from
Oct 18, 2021

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Oct 14, 2021 •
edited
Loading

Details

Send money option disabled for IOU restricted accounts

Fixed Issues

$ #5728

Tests & QA Steps

  1. Go to any IOU Restricted chats. Example: Concierge
  2. Click + icon from Compose box.
  3. Send Money option will not be available now.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

WEB

Screenshot 2021-10-15 at 12 05 12 AM

Screenshot 2021-10-15 at 12 05 33 AM

Mobile Web

MWEB
Simulator Screen Shot - iPhone 12 - 2021-10-15 at 00 01 05
Simulator Screen Shot - iPhone 12 - 2021-10-15 at 00 01 48

Desktop

DESKTOP

Screenshot 2021-10-15 at 12 08 36 AM

Screenshot 2021-10-15 at 12 08 11 AM

iOS

IOS
Simulator Screen Shot - iPhone 12 - 2021-10-14 at 23 58 05
Simulator Screen Shot - iPhone 12 - 2021-10-14 at 23 54 03

Android

ANDROID
Screenshot_1634236153
Screenshot_1634236145

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner October 14, 2021 17:06
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team October 14, 2021 17:06
@Luke9389
Copy link
Contributor

Thanks @Santhosh-Sellavel! Would you mind including screens of the same thing for Chronos, and also the intended behavior working with a normal chat?

@Santhosh-Sellavel
Copy link
Collaborator Author

@Luke9389 Updated screens for mobiles with Chronos & normal chat

@Santhosh-Sellavel
Copy link
Collaborator Author

@Luke9389 Updated for all now.

@Luke9389 Luke9389 changed the title [HOLD N6] Send money disabled for restricted accounts Send money disabled for restricted accounts Oct 18, 2021
@Luke9389 Luke9389 merged commit 34442f4 into Expensify:main Oct 18, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Luke9389 in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Santhosh-Sellavel Santhosh-Sellavel deleted the santhosh_disable_send_money_for_restricted_accounts branch November 4, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke9389 Luke9389 Luke9389 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Santhosh-Sellavel @Luke9389 @OSBotify