[HOLD for payment 2021-11-04] Send money option is visible in restricted accounts - @Santhosh-Sellavel

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to Chronos conversation
2. Click on the + button in compose box

Expected Result:

There should not be an option for sending money in Chronos conversation

Actual Result:

The option to send money is visible in Chronos conversation.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.7-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633547417452400

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Santhosh-Sellavel]

Proposal

Like we do here for other IOU Operations as shown below.

App/src/pages/home/report/ReportActionCompose.js

Lines 536 to 538 in a860c59

	menuItems={[
	...(!hasExcludedIOUEmails
	&& Permissions.canUseIOU(this.props.betas) ? [

We need to add a check !hasExcludedIOUEmails here also to restrict Send Money

App/src/pages/home/report/ReportActionCompose.js

Lines 563 to 573 in a860c59

	...(Permissions.canUseIOUSend(this.props.betas) && !hasMultipleParticipants ? [
	{
	icon: Send,
	text: this.props.translate('iou.sendMoney'),
	onSelected: () => {
	Navigation.navigate(
	ROUTES.getIOUSendRoute(
	this.props.reportID,
	),
	);
	},

[MelvinBot]

@yuwenmemon Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to @Luke9389 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NicMendonca]

Upwork job link: https://www.upwork.com/jobs/~01c0d230008a8452e6

[Santhosh-Sellavel]

@Luke9389 Proposal is here. In case if you had missed it thanks!

[Luke9389]

Thanks for the bump @Santhosh-Sellavel, you can go ahead and make a PR. 🎉

[Santhosh-Sellavel]

Assign me this @Luke9389

[mallenexpensify]

Not showing for me in Desktop

[Santhosh-Sellavel]

@mallenexpensify I think send money option is not available in staging yet.

[mallenexpensify]

Thanks @Santhosh-Sellavel , I did a lil more digging, it looks like it'll hopefully be live soon

[isagoico]

I still see it displayed in Chronos in staging

[parasharrajat]

@isagoico PR is on HOLD.

[NicMendonca]

N6 hold lifted 🚀 PR hasn't been deployed to staging yet.

[Luke9389]

I think it hasn't been deployed because there are current deploy blockers on staging. Could be wrong, but I don't think we've done an /App deploy all week.

[NicMendonca]

Not overdue, awaiting payment

[NicMendonca]

Paid!

[Santhosh-Sellavel]

Thanks! @NicMendonca
It does qualifies for N6 hold bonus too right?

[NicMendonca]

@Santhosh-Sellavel Shoot sorry, I missed that. Just sent the bonus now.