Copy Option Enabled for small screen devices also #5746
Conversation
|
@Santhosh-Sellavel Could you please test it on the other remaining platforms and attach screens for those? Just to make sure they are not affected. |
|
I've tested out, It works well. As requested I'll update screenshots later (ASAP). If you are facing any issues let me know. Thanks! cc: @parasharrajat |
@parasharrajat Thanks for bringing this up. I was looking at this again. There is some minor issue with the web/desktop. Copy button should be close to the email, but it's weirdly away from the email. When I created this issue in staging,
Even in staging its away from email.
The difference is caused by the PR #5532 |
|
@parasharrajat |
|
Yes, I noticed that. Thanks for looking into it. Unfortunately that PR is over the regression period. we are working with the copy icon in this PR thus would you like to fix that too? I am sure that is a very minor issue. what do you think? |
|
No issues will handle it here. @parasharrajat |
|
Thank you. I will wait for the fix and review it again. |
|
Agree, copy button should be closer to the email address. |
There was a problem hiding this comment.
LGTM.
Ready for final review after n6-hold is lifted. cc. @Luke9389
Santhosh-Sellavel
changed the title
|
@Santhosh-Sellavel Could you please merge the main branch? There have been tremendous changes during the N6 launch. It would be great to see if we don't have any issues due to that in this PR. Thanks. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Details
Just enabled copy email/phone number options for small screen devices.
Fixed Issues
$ #4905
Tests & QA Steps
Tested On
Screenshots
Mobile Web
iOS
iOS_02.mp4
Android
Desktop
Web