Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: email overflow in Details page on Mobile devices #5532

Merged
merged 2 commits into from
Sep 29, 2021
Merged

fix: email overflow in Details page on Mobile devices #5532

merged 2 commits into from
Sep 29, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Sep 25, 2021 •
edited
Loading

Details

Fixed Issues

$ #5422

Tests | QA Steps

  1. Go to staging.new.expensify.com on MWeb.
  2. Login with any account
  3. Select user with long email
  4. Click on user Profile.
  5. Email should be trimmed with an ellipsis instead of oveflowing.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

Screenshot 2021-09-27 04:24:44

iOS

Android

Screenshot 2021-09-27 04:48:44

@parasharrajat parasharrajat requested a review from a team as a code owner September 25, 2021 20:55
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team September 25, 2021 20:55
chiragsalian
chiragsalian approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit e1d0220 into Expensify:main Sep 29, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Sep 30, 2021
Closed
15 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.3-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Santhosh-Sellavel Santhosh-Sellavel mentioned this pull request Oct 11, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @chiragsalian