Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styles for ul & ol #5364

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

parasharrajat
Copy link
Member

Details

#5008 (comment)

Fixed Issues

$ #5008

Tests | QA Steps

  1. Lunch the app
  2. Log in with expensifail account
  3. On Search box - find Chronos
  4. Text - Top

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

fix

iOS

Android

fix

@parasharrajat parasharrajat requested a review from a team as a code owner September 20, 2021 19:43
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team September 20, 2021 19:43
@parasharrajat
Copy link
Member Author

@johnmlee101 Ready to roll.

Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yassss LGTM!

@johnmlee101
Copy link
Contributor

OH @parasharrajat I hate having to ask, can you pull main into this branch? a month of changes can introduce weirdness 😄

@parasharrajat
Copy link
Member Author

parasharrajat commented Oct 18, 2021

Pulling now. But I found no differences.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @johnmlee101 in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants