[HOLD for payment 2021-11-04] Chat - Chronos message is cut off at the edge and not fully visible

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Lunch the app
2. Log in with expensifail account
3. On Search box - find Chronos
4. Text - Top

Expected Result:

Chronos messages are fully visible.

Actual Result:

Chronos message isn't fully visible, it is cut off at the end

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android
• Mobile Web

Version Number:
1.0.91-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Christinadobrzyn]

External job created in Upwork - https://www.upwork.com/jobs/~0135dabda6dbb82f78
Internal job created in Upwork - https://www.upwork.com/ab/applicants/1433592402430713856/job-details

[MelvinBot]

Triggered auto assignment to @johnmlee101 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[equationalapplications]

I launched the web app in my development environment and logged in with my email. I clicked the search icon, but I can't find Chronos.

[pROFESOR11]

Hi @kavimuru ,
What exactly is expensifail account and how can I login with that?
I guess I need to login with that specific account to be able to reproduce the issue.

[Christinadobrzyn]

Hi @pROFESOR11! Sorry for the delayed response, Expensifail is our test account. You can create a test account to our NewDot product following the setup details in this article.

@equationalapplications - Chronos is a 'contact' option in the NewDot chat. To start a conversation with Chronos, click the green + icon > New Chat > type Chronos.

[Christinadobrzyn]

Doubled price to $500 - still waiting on proposals.

[pROFESOR11]

@Christinadobrzyn Thanks for your reply. Well, I want to work the issue, but I am not sure what I am doing wrong, for some reason I can't reproduce the issue. I can't find Chronos in contacts. I tried to manually add chronos@expensify.com and wrote "Hey there!", but got no response. Should I write something specific to get an answer as in the issue description?

Screen.Recording.2021-09-13.at.11.52.54.mov

[parasharrajat]

This issue is seemed to be fixed now. Please re-test @isagoico .

[equationalapplications]

Hi @pROFESOR11! Sorry for the delayed response, Expensifail is our test account. You can create a test account to our NewDot product following the setup details in this article.

@equationalapplications - Chronos is a 'contact' option in the NewDot chat. To start a conversation with Chronos, click the green + icon > New Chat > type Chronos.

@Christinadobrzyn thank you. I too cannot find Chronos after starting a new chat and searching for Chronos.

[Christinadobrzyn]

Thanks for confirming @equationalapplications!

Based on what @parasharrajat mentioned above, we'll have @isagoico or @kavimuru test this to see if it's fixed.

[parasharrajat]

@isagoico Please retest.

[Christinadobrzyn]

Pinged Isabella in Slack

[isagoico]

We were able to reproduce the issue in latest build

Screen_Recording_20210916-130619_New.Expensify.mp4

[parasharrajat]

Good Thanks @isagoico, I will look closely. Maybe come up with follow-up questions.

[Christinadobrzyn]

Looks like we're still waiting on proposals for this!

[equationalapplications]

I am not able to find Chronos in the chat search still running on my localhost

screenshot.mp4

.

[equationalapplications]

Also, I cannot add a test account from the development web server on localhost. The avatar for the test email appears, but I cannot click it.

Screenshot2.mp4

.

[equationalapplications]

Also, I cannot find Chronos in new.expensify.com in the browser.

[parasharrajat]

Finally, the solution is found.

Proposal

1. Li items are extending beyond the parent width and trying flexShrink:1 which was suggested from Lib was not working as the container was allowing unrestricted width.

To fix this we have to restrict the container's width and then respectively ul tags.

We have to add styles for ul & ol in

App/src/styles/styles.js

Line 2036 in 0a3da2e

tagStyles: {

      ul: {
            maxWidth: '100%',
            flex: 1, //Optional not needed but seems useful to me.
        },

Then we apply maxWidth: '100%' to

App/src/styles/styles.js

Line 1051 in 0a3da2e

chatItemMessage: {

which fixes this issue.

BEFORE	AFTER

[johnmlee101]

Looks good to me @parasharrajat !

[johnmlee101]

cc @Christinadobrzyn

[Christinadobrzyn]

Awesome! Hired @parasharrajat in Upwork.

[Christinadobrzyn]

still on hold for n6

[kadiealexander]

Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.

[Christinadobrzyn]

Not overdue - on hold for N6

[Christinadobrzyn]

On hold for n6

[Christinadobrzyn]

N6 hold is removed as the newsletter has deployed.

Here's the PR for this job - a $250 bonus will also apply to this job!

[Christinadobrzyn]

PR appears to be in staging - not overdue - waiting

[Christinadobrzyn]

7-day production window is upon us. Paid @parasharrajat in Upwork and included a $250 bonus. Closing this. 🎉