Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Revert "[No QA] Callable buildIOS workflow" #50268

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jasperhuangg
Copy link
Contributor

Reverts #50123

Fixes https://expensify.slack.com/archives/C03V9A4TB/p1728064608139199, causing iOS staging builds to fail

@jasperhuangg jasperhuangg self-assigned this Oct 4, 2024
@jasperhuangg jasperhuangg requested a review from a team as a code owner October 4, 2024 19:35
@melvin-bot melvin-bot bot removed the request for review from a team October 4, 2024 19:35
Copy link

melvin-bot bot commented Oct 4, 2024

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jasperhuangg jasperhuangg merged commit 209d7a5 into main Oct 4, 2024
7 of 9 checks passed
@jasperhuangg jasperhuangg deleted the revert-50123-Rory-CallableIOSBuild branch October 4, 2024 19:44
@melvin-bot melvin-bot bot added the Emergency label Oct 4, 2024
Copy link

melvin-bot bot commented Oct 4, 2024

@jasperhuangg looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@jasperhuangg jasperhuangg changed the title Revert "[No QA] Callable buildIOS workflow" [CP Staging] Revert "[No QA] Callable buildIOS workflow" Oct 4, 2024
OSBotify pushed a commit that referenced this pull request Oct 4, 2024
…SBuild

Revert "[No QA] Callable buildIOS workflow"

(cherry picked from commit 209d7a5)

(CP triggered by jasperhuangg)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 4, 2024
@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.0.44-12 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Copy link
Contributor

github-actions bot commented Oct 4, 2024

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.44-12 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants