[No QA] Callable buildIOS workflow #50123

roryabraham · 2024-10-03T00:21:31Z

Details

Creates a callable iOS build workflow.

Fixed Issues

$ n/a - related to CP to prod

Tests

We'll have to live-test the main deploy but we can test this branch with AdHoc builds to make sure that works.

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

none

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-03T00:21:36Z

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

github-actions · 2024-10-03T23:40:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/50123/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/50123/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/50123/NewExpensify.dmg	https://50123.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

AndrewGable · 2024-10-03T23:42:42Z

.github/workflows/buildIOS.yml

+      - name: Upload iOS sourcemaps
+        uses: actions/upload-artifact@v4
+        with:
+          name: ios-sourcemaps-artifact


Should it be ios-artifact-sourcemaps?

Also do we do anything with this?

I kept it as ios-sourcemaps-artifact intentionally, because that's what it was called before. I'm not sure but I think we might download this artifact as part of some debug/development tools (which is why I didn't want to rename it unnecessarily). I can look into it

In the only other reference in this repo, it's just uploaded to the GitHub Release. I think it might be downloaded from there manually to debug issues reported in #newdot-quality though

Ah - The only reason I said is because I'm not sure we will download it pattern: ios-artifact-*? But if it's downloaded elsewhere already, that sounds good

ended up renaming this to ios-artifact-sourcemaps for consistency. It will still get uploaded to the GitHub Release

roryabraham · 2024-10-03T23:47:58Z

noticed a 🐛, fixing it

roryabraham · 2024-10-03T23:49:35Z

fixed!

roryabraham · 2024-10-03T23:51:42Z

lol, found another 😂

roryabraham · 2024-10-03T23:56:13Z

Fixed!

AndrewGable · 2024-10-03T23:59:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

N/A - No user code

Android: mWeb Chrome

N/A - No user code

iOS: Native

N/A - No user code

iOS: mWeb Safari

N/A - No user code

MacOS: Chrome / Safari

N/A - No user code

MacOS: Desktop

N/A - No user code

roryabraham · 2024-10-04T00:06:30Z

Not going to wait for performance tests, going to merge this one to get it tested.

melvin-bot · 2024-10-04T00:06:40Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[No QA] Callable buildIOS workflow (cherry picked from commit 6606f1d) (CP triggered by roryabraham)

OSBotify · 2024-10-04T00:16:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-04T00:29:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/50123/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/50123/NewExpensify.dmg	https://50123.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2024-10-04T00:46:24Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.44-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

github-actions · 2024-10-04T17:57:54Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.44-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

github-actions · 2024-10-04T20:59:16Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.44-12 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham self-assigned this Oct 3, 2024

roryabraham added the Ready To Build label Oct 3, 2024

roryabraham force-pushed the Rory-CallableIOSBuild branch 3 times, most recently from d8998c4 to 5ebe423 Compare October 3, 2024 01:17

This comment has been minimized.

Sign in to view

roryabraham added 12 commits October 3, 2024 13:14

Save draft state

d905009

Finish buildIOS workflow

15a61d7

Use callable workflow in deploy.yml

562be33

Use callable ios workflow in testBuild

00a17ef

exportS3Path singular

c43831e

Fix upload step

3bf805d

Fix typo in Fastfile

ae65b87

Update buildIOS with AdHoc-specific steps

2db0222

Make pull_request_number type: string to make lint happy

2de022b

Add missing workflow-level outputs

d3c38d9

Fix needs

cf033ca

Don't access env where it's not available

6bdeb2c

roryabraham force-pushed the Rory-CallableIOSBuild branch from 5ebe423 to 6bdeb2c Compare October 3, 2024 20:14

roryabraham changed the title ~~[HOLD #49434] [No QA] Callable iOS build workflow~~ [HOLD #49434] [No QA] Callable buildIOS workflow Oct 3, 2024

roryabraham changed the title ~~[HOLD #49434] [No QA] Callable buildIOS workflow~~ [No QA] Callable buildIOS workflow Oct 3, 2024

Debug provisioning profile stuff

8deb907

This comment was marked as outdated.

Sign in to view

Correctly expand provisioningProfile variable

346359e

This comment was marked as outdated.

Sign in to view

Remove spaces from .ipa file names

d4bf58a

This comment was marked as outdated.

Sign in to view

AndrewGable reviewed Oct 3, 2024

View reviewed changes

roryabraham changed the title ~~[No QA] Callable buildIOS workflow~~ [WIP][No QA] Callable buildIOS workflow Oct 3, 2024

Fix ipa path

bcb43d5

roryabraham changed the title ~~[WIP][No QA] Callable buildIOS workflow~~ [No QA] Callable buildIOS workflow Oct 3, 2024

roryabraham changed the title ~~[No QA] Callable buildIOS workflow~~ [WIP][No QA] Callable buildIOS workflow Oct 3, 2024

Standardize and fix workflow artifacts, correctly upload to release

0e59102

roryabraham changed the title ~~[WIP][No QA] Callable buildIOS workflow~~ [No QA] Callable buildIOS workflow Oct 3, 2024

roryabraham requested a review from AndrewGable October 3, 2024 23:56

AndrewGable approved these changes Oct 3, 2024

View reviewed changes

roryabraham merged commit 6606f1d into main Oct 4, 2024
16 of 18 checks passed

roryabraham deleted the Rory-CallableIOSBuild branch October 4, 2024 00:06

melvin-bot bot added the Emergency label Oct 4, 2024

roryabraham removed the Emergency label Oct 4, 2024

OSBotify pushed a commit that referenced this pull request Oct 4, 2024

Merge pull request #50123 from Expensify/Rory-CallableIOSBuild

469e975

[No QA] Callable buildIOS workflow (cherry picked from commit 6606f1d) (CP triggered by roryabraham)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 4, 2024

github-actions bot mentioned this pull request Oct 4, 2024

Deploy Checklist: New Expensify 2024-10-03 #50125

Closed

63 tasks

jasperhuangg mentioned this pull request Oct 4, 2024

[CP Staging] Revert "[No QA] Callable buildIOS workflow" #50268

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Callable buildIOS workflow #50123

[No QA] Callable buildIOS workflow #50123

roryabraham commented Oct 3, 2024 •

edited

Loading

melvin-bot bot commented Oct 3, 2024

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Oct 3, 2024

AndrewGable Oct 3, 2024

AndrewGable Oct 3, 2024

roryabraham Oct 3, 2024 •

edited

Loading

roryabraham Oct 3, 2024

AndrewGable Oct 3, 2024

roryabraham Oct 3, 2024

roryabraham commented Oct 3, 2024

roryabraham commented Oct 3, 2024

roryabraham commented Oct 3, 2024

roryabraham commented Oct 3, 2024

AndrewGable commented Oct 3, 2024

roryabraham commented Oct 4, 2024

melvin-bot bot commented Oct 4, 2024

OSBotify commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

[No QA] Callable buildIOS workflow #50123

[No QA] Callable buildIOS workflow #50123

Conversation

roryabraham commented Oct 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 3, 2024

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Oct 3, 2024

AndrewGable Oct 3, 2024

Choose a reason for hiding this comment

AndrewGable Oct 3, 2024

Choose a reason for hiding this comment

roryabraham Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

roryabraham Oct 3, 2024

Choose a reason for hiding this comment

AndrewGable Oct 3, 2024

Choose a reason for hiding this comment

roryabraham Oct 3, 2024

Choose a reason for hiding this comment

roryabraham commented Oct 3, 2024

roryabraham commented Oct 3, 2024

roryabraham commented Oct 3, 2024

roryabraham commented Oct 3, 2024

AndrewGable commented Oct 3, 2024

Reviewer Checklist

Screenshots/Videos

roryabraham commented Oct 4, 2024

melvin-bot bot commented Oct 4, 2024

OSBotify commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

roryabraham commented Oct 3, 2024 •

edited

Loading

roryabraham Oct 3, 2024 •

edited

Loading