Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: remove transaction after navigate" #49096

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Revert "fix: remove transaction after navigate" #49096

merged 1 commit into from
Sep 12, 2024

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Sep 12, 2024 •
edited
Loading

Fixed issues

$ #49052
$ #49066
$ #49094

Reverts #48055

@luacmartins luacmartins self-assigned this Sep 12, 2024
@luacmartins luacmartins marked this pull request as ready for review September 12, 2024 16:07
@luacmartins luacmartins requested a review from a team as a code owner September 12, 2024 16:07
@melvin-bot melvin-bot bot requested review from MonilBhavsar and removed request for a team September 12, 2024 16:08
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 12, 2024

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini
neil-marcellini approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert, looks good

@luacmartins luacmartins merged commit fae105b into main Sep 12, 2024
13 of 16 checks passed
@luacmartins luacmartins deleted the revert-48055-fix/45576 branch September 12, 2024 16:24
@melvin-bot melvin-bot bot added the Emergency label Sep 12, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 12, 2024

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@luacmartins
Copy link
Contributor Author

Straight revert, didn't complete the checklists

OSBotify pushed a commit that referenced this pull request Sep 12, 2024
@luacmartins @OSBotify
Merge pull request #49096 from Expensify/revert-48055-fix/45576
9294302 
Revert "fix: remove transaction after navigate"

(cherry picked from commit fae105b)

(CP triggered by luacmartins)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Sep 12, 2024
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Closed
49 tasks
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neil-marcellini neil-marcellini neil-marcellini approved these changes

@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

Assignees

@luacmartins luacmartins

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @OSBotify @neil-marcellini