-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove transaction after navigate #48055
Conversation
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@daledah I am facing this issue in ios native Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-09-02.at.19.17.31.mp4 |
@alitoshmatov is that present on main too? |
No not reproducible, I think solution in this PR caused that |
Thanks for confirming! @daledah could you please investigate? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daledah it seems like we have a bug to fix #48055 (comment)
@luacmartins I'll update soon. |
@alitoshmatov I can't reproduce the bug mentioned in #48055 (comment), did you reproduce this in any special condition? |
Bump @daledah @alitoshmatov, let's get this one to the finish line |
@luacmartins I can't reproduce the bug mentioned in #48055 (comment), for me this only happens for a brief moment before the screen is rendered correctly. |
@alitoshmatov can you still reproduce the issue? |
I couldn't reproduce it now, maybe it was some issue with my local setup. I will wrap up the review asap |
Reviewer Checklist
Screenshots/VideosAndroid: Nativetransaction-android.movAndroid: mWeb Chrometransaction-mweb.moviOS: Nativetransaction-ios.mp4iOS: mWeb Safaritransaction-safari.mp4MacOS: Chrome / Safaritransaction-web.movMacOS: Desktoptransaction-desktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@dangrous we're reverting this PR |
FYI this PR was reverted #45576 (comment) |
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.33-4 🚀
|
Details
Fixed Issues
$ #45576
PROPOSAL: #45576 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-08-28.at.13.36.21.mov
Android: mWeb Chrome
Screen.Recording.2024-08-28.at.01.03.25.mp4
iOS: Native
Screen.Recording.2024-08-28.at.01.09.29.mov
iOS: mWeb Safari
Screen.Recording.2024-08-28.at.01.05.44.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-27.at.14.02.06.mov
MacOS: Desktop
Screen.Recording.2024-08-28.at.01.23.24.mov