Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy and translations for 'importing ___' progress step messages for NetSuite #47749

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Add copy and translations for 'importing ___' progress step messages for NetSuite #47749

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52ffca9
Add copy and translations for 'importing ___' progress step messages …
yuwenmemon Aug 20, 2024
981de5c
Personalizidas
yuwenmemon Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2180,7 +2180,10 @@ const CONST = {
NETSUITE_SYNC_ACCOUNTS: 'netSuiteSyncAccounts',
NETSUITE_SYNC_CURRENCIES: 'netSuiteSyncCurrencies',
NETSUITE_SYNC_CATEGORIES: 'netSuiteSyncCategories',
NETSUITE_SYNC_IMPORT_CUSTOM_LISTS: 'netSuiteSyncImportCustomLists',
NETSUITE_SYNC_IMPORT_EMPLOYEES: 'netSuiteSyncImportEmployees',
NETSUITE_SYNC_IMPORT_SUBSIDIARIES: 'netSuiteSyncImportSubsidiaries',
NETSUITE_SYNC_IMPORT_VENDORS: 'netSuiteSyncImportVendors',
NETSUITE_SYNC_REPORT_FIELDS: 'netSuiteSyncReportFields',
NETSUITE_SYNC_TAGS: 'netSuiteSyncTags',
NETSUITE_SYNC_UPDATE_DATA: 'netSuiteSyncUpdateConnectionData',
Expand Down
6 changes: 6 additions & 0 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3288,6 +3288,12 @@ export default {
return 'Marking Expensify reports as reimbursed';
case 'netSuiteSyncExpensifyReimbursedReports':
return 'Marking NetSuite bills and invoices as paid';
case 'netSuiteSyncImportCustomLists':
return 'Importing custom lists';
case 'netSuiteSyncImportSubsidiaries':
return 'Importing subsidiaries';
case 'netSuiteSyncImportVendors':
return 'Importing vendors';
case 'intacctCheckConnection':
return 'Checking Sage Intacct connection';
case 'intacctImportDimensions':
Expand Down
6 changes: 6 additions & 0 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3268,6 +3268,12 @@ export default {
return 'Actualizando información de conexión';
case 'netSuiteSyncNetSuiteReimbursedReports':
return 'Marcando informes de Expensify como reembolsados';
case 'netSuiteSyncImportCustomLists':
return 'Importando listas personalizado';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this verified? I would have said Importando listas personalizadas off the top of my head.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using personalizado at quite a few places. Does that mean we should it update it at other places too? I think we had used DeepL for these translations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word personalizado by itself is fine, it's the adjective agreement that doesn't work here. listas is plural and feminine, so the adjective after it should be matched accordingly. We have other translations that already follow this, e.g.:

  • un calendario personalizado (calendario is singular and masculine)
  • Establece una descripción personalizada (singular feminine)
  • Controles de gastos y límites personalizados (plural masculine)

case 'netSuiteSyncImportSubsidiaries':
return 'Importando subsidiarias';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this one, sounds like subsidiario/a is more commonly used as an adjective, whereas the noun would be filial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subsidiarias is what NetSuite uses in product when you turn it into Spanish 🤷🏽‍♂️

case 'netSuiteSyncImportVendors':
return 'Importando proveedores';
case 'netSuiteSyncExpensifyReimbursedReports':
return 'Marcando facturas y recibos de NetSuite como pagados';
case 'intacctCheckConnection':
Expand Down
Loading