Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy and translations for 'importing ___' progress step messages for NetSuite #47749

Merged
merged 2 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/CONST.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2180,7 +2180,10 @@ const CONST = {
NETSUITE_SYNC_ACCOUNTS: 'netSuiteSyncAccounts',
NETSUITE_SYNC_CURRENCIES: 'netSuiteSyncCurrencies',
NETSUITE_SYNC_CATEGORIES: 'netSuiteSyncCategories',
NETSUITE_SYNC_IMPORT_CUSTOM_LISTS: 'netSuiteSyncImportCustomLists',
NETSUITE_SYNC_IMPORT_EMPLOYEES: 'netSuiteSyncImportEmployees',
NETSUITE_SYNC_IMPORT_SUBSIDIARIES: 'netSuiteSyncImportSubsidiaries',
NETSUITE_SYNC_IMPORT_VENDORS: 'netSuiteSyncImportVendors',
NETSUITE_SYNC_REPORT_FIELDS: 'netSuiteSyncReportFields',
NETSUITE_SYNC_TAGS: 'netSuiteSyncTags',
NETSUITE_SYNC_UPDATE_DATA: 'netSuiteSyncUpdateConnectionData',
Expand Down
6 changes: 6 additions & 0 deletions src/languages/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3288,6 +3288,12 @@ export default {
return 'Marking Expensify reports as reimbursed';
case 'netSuiteSyncExpensifyReimbursedReports':
return 'Marking NetSuite bills and invoices as paid';
case 'netSuiteSyncImportCustomLists':
return 'Importing custom lists';
case 'netSuiteSyncImportSubsidiaries':
return 'Importing subsidiaries';
case 'netSuiteSyncImportVendors':
return 'Importing vendors';
case 'intacctCheckConnection':
return 'Checking Sage Intacct connection';
case 'intacctImportDimensions':
Expand Down
12 changes: 9 additions & 3 deletions src/languages/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2690,12 +2690,12 @@ export default {
},
},
customLists: {
title: 'Listas personalizados',
addText: 'Añadir lista personalizado',
title: 'Listas personalizadas',
addText: 'Añadir lista personalizada',
recordTitle: 'Lista personalizado',
helpLink: CONST.NETSUITE_IMPORT.HELP_LINKS.CUSTOM_LISTS,
helpLinkText: 'Ver instrucciones detalladas',
helpText: ' sobre cómo configurar listas personalizado.',
helpText: ' sobre cómo configurar listas personalizada.',
emptyTitle: 'Añadir una lista personalizado',
fields: {
listName: 'Nombre',
Expand Down Expand Up @@ -3268,6 +3268,12 @@ export default {
return 'Actualizando información de conexión';
case 'netSuiteSyncNetSuiteReimbursedReports':
return 'Marcando informes de Expensify como reembolsados';
case 'netSuiteSyncImportCustomLists':
return 'Importando listas personalizadas';
case 'netSuiteSyncImportSubsidiaries':
return 'Importando subsidiarias';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this one, sounds like subsidiario/a is more commonly used as an adjective, whereas the noun would be filial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subsidiarias is what NetSuite uses in product when you turn it into Spanish 🤷🏽‍♂️

case 'netSuiteSyncImportVendors':
return 'Importando proveedores';
case 'netSuiteSyncExpensifyReimbursedReports':
return 'Marcando facturas y recibos de NetSuite como pagados';
case 'intacctCheckConnection':
Expand Down
Loading