-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Track tax switch does not appear grayed out when enabled/disabled offline #43347
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c440531
fix: Track tax switch does not appear grayed out when enabled/disable…
nkdengineer da9699a
fix: move pending fields to custom units
nkdengineer 5678b7c
Merge branch 'main' into fix/43318
nkdengineer ae6835c
merge main
nkdengineer 8ba10d8
fix: typescript
nkdengineer 0da0974
fix crash app
nkdengineer 8fe55a0
Merge branch 'main' into fix/43318
nkdengineer 5a6e22d
Merge branch 'main' into fix/43318
nkdengineer a8370e8
fix: add offline page when isOffline and don't have data
nkdengineer 5c0150c
clean code
nkdengineer 17949c5
fix crash app bug
nkdengineer 681902d
Merge branch 'main' into fix/43318
nkdengineer f600d6e
Merge branch 'main' into fix/43318
nkdengineer 021273f
fix: crash app
nkdengineer 8e72c47
Merge branch 'main' into fix/43318
nkdengineer adc8f72
Merge branch 'main' into fix/43318
nkdengineer 700fc20
Merge branch 'main' into fix/43318
nkdengineer c183c05
add full page blocking view
nkdengineer 351e118
Merge branch 'main' into fix/43318
nkdengineer f9775a2
make default value as optional
nkdengineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
defaultValue
can beundefined
, then we need to mark it as optional inUnitSelectorProps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, lets make this field optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkdengineer ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MonilBhavsar @srikarparsi I updated.