Fix isDisabled check for the payments button

[jasperhuangg]

Details

See linked issue

Fixed Issues

$ #3609

Tests/QA

1. Sign into an account. Navigate to the payments page <baseURL>/settings/payments
2. Set a Paypal username.
3. Verify that the button is disabled once you've set one, and the input isn't editable
4. Sign into the same account but on a different client and navigate to the payments page. Verify that the payment button is disabled and the input isn't editable.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Desktop

desktop.mp4

iOS

ios.mp4

Web

web.mp4

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[isagoico]

@jasperhuangg @Julesssss I'm a bit confused with the expected result of this PR. In the steps it says:
Verify that the payment button is disabled and the input isn't editable.
There's also this new PR that changes the flow a bit too #3727

So can you verify if the following is correct:

1. Navigate to settings/payments
2. Click on "Add new payment method"
3. Click on PayPal.me
4. Add a Paypal.me account and save
5. Click on add new Payment method again
6. Click on PayPal.me
7. Verify you can add a new Paypal account

Grabando.194.mp4

[roryabraham]

@isagoico That looks correct to me! cc @kevinksullivan Can you confirm?

[roryabraham]

Actually, I'm 99% sure that this is correct, so I'm going to check it off on the deploy checklist.

[kevinksullivan]

Hm no, there should not be a concept of adding multiple paypal.me usernames for a single user. All we do with a paypal.me login is auto-fill the $ amount and recipient paypal handle when we link a payer out to paypal.me. In other words, we don't let a user choose the specific paypal.me account of the recipient when making the payment.

Ideally we let a user add paypal.me once, and tap that existing username for editing purposes. Otherwise there shouldn't bee an option to add another username. I will create a separate GH for this one to follow up.

[kevinksullivan]

@jasperhuangg do you know if this PR will allow you to add multiple paypal.me user names? Or, once you have added paypal.me once, and then you add one "again", are we just editing the existing paypal.me login?

GH is here as a follow up.

[Julesssss]

My understanding here is that this PR simple fixed the original functionality:

You should be able to set a PayPal username exactly once.

Ideally we let a user add paypal.me once, and tap that existing username for editing purposes.

I agree that this should be the case, so either that was not originally implemented, or this PR fix missed this requirement.

@jasperhuangg are you able to confirm?