Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed scrolling when focusing on the edit box for old message #3551

Merged
merged 4 commits into from
Jun 14, 2021
Merged

fixed scrolling when focusing on the edit box for old message #3551

merged 4 commits into from
Jun 14, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jun 11, 2021 •
edited
Loading

Details

Fixed Issues

Fixes #3545

Tests | QA Steps

  1. Open any conversation on Ecash Mobile.
  2. Hover over a sent message and click on the edit comment option in the menu
  3. Focus on the edit box, Start editing the message.
  4. When the keyboard opens, you should be able to type in the edit box and chat should not scroll. Like
    https://user-images.githubusercontent.com/43996225/121611132-92c64480-ca25-11eb-8aaa-8c5204107ff7.mp4

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

scroll.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner June 11, 2021 18:18
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team June 11, 2021 18:18
@parasharrajat parasharrajat mentioned this pull request Jun 11, 2021
Closed
@parasharrajat
Copy link
Member Author

Updated. Thanks

@nickmurray47 nickmurray47 merged commit 35d0848 into Expensify:main Jun 14, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jun 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.68-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat mentioned this pull request Jun 16, 2021
Closed
kidroca
kidroca reviewed Jun 19, 2021
View reviewed changes
Copy link
Contributor

@kidroca kidroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've forgotten to test the case where the view should still scroll to the bottom
with the current changes it never will

And now a commercial break for my IDE: Webostorm: https://lp.jetbrains.com/webstorm-ide-2/

image

  • it also helped me trace the code to this PR

src/libs/ReportActionComposeFocusManager.js Show resolved Hide resolved
src/pages/home/report/ReportActionsView.js Show resolved Hide resolved
@parasharrajat parasharrajat mentioned this pull request Jun 19, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@rushatgabhane rushatgabhane mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidroca kidroca kidroca left review comments

@Julesssss Julesssss Julesssss approved these changes

@nickmurray47 nickmurray47 nickmurray47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tapping on Edit Message scrolls down to the bottom to the compose box
5 participants
@parasharrajat @OSBotify @Julesssss @kidroca @nickmurray47