Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Edit comment - Editing a message up in the history will make the chat scroll down #3248

Closed
isagoico opened this issue May 31, 2021 · 9 comments

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Message is in focus, user is able to edit it and submit the change

Actual Result:

User is able to edit the message, but message loses focus - the screen is scrolled down until the newest message

Action Performed:

  1. Open app and login
  2. Choose a chat that has a lot of messages (so you have to scroll up)
  3. Long press the message and select edit

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS ✔️
Android
Desktop App
Mobile Web

Version Number: 1.0.58-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5093805_video.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@MelvinBot
Copy link

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jasperhuangg
Copy link
Contributor

I don't have a physical iOS device to test with (it's not reproducible in a simulator and I assume it's because it doesn't pull up the keyboard). Going to throw this back into the pool!

@jasperhuangg jasperhuangg removed their assignment Jun 1, 2021
@parasharrajat
Copy link
Member

@jasperhuangg You can open t he soft keyboard on simulator as well.

@isagoico
Copy link
Author

isagoico commented Jun 7, 2021

Issue reproducible today during KI retests

1 similar comment
@isagoico
Copy link
Author

Issue reproducible today during KI retests

@parasharrajat
Copy link
Member

@isagoico This is fixed #3551

@isagoico
Copy link
Author

Issue not reproducible during KI retests (First week)

@isagoico
Copy link
Author

Issue not reproducible during KI retests (Second week)

@isagoico
Copy link
Author

isagoico commented Jul 5, 2021

Issue not reproducible during KI retests (Third week) - Closing

@isagoico isagoico closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants