-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Receipt Component to Money Request confirmation page #34533
Adds Receipt Component to Money Request confirmation page #34533
Conversation
…rRefactorRequestConfirmationList
…tions/cdanwards/add-receipt-component
…tions/cdanwards/add-receipt-component
…tions/cdanwards/add-receipt-component
@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Let me do C+ review as I am assigned in linked issue |
I noticed that some of the uploaded videos accidentally contained personal info. Redoing those videos. |
Example screen recordings have been updated! |
@aimane-chnaif let me know if I can help get this reviewed. |
The review will be completed on Monday |
src/components/MoneyTemporaryForRefactorRequestConfirmationList.js
Outdated
Show resolved
Hide resolved
src/components/MoneyTemporaryForRefactorRequestConfirmationList.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>
…t.js Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>
…t.js Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>
Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>
@@ -222,6 +223,9 @@ function MoneyRequestConfirmationList(props) { | |||
const isSplitBill = props.iouType === CONST.IOU.TYPE.SPLIT; | |||
const isTypeSend = props.iouType === CONST.IOU.TYPE.SEND; | |||
|
|||
// A flag for checking if the associated policy is of type Team or Corporate ("Control" or "Collect") | |||
const isFromPaidPolicy = props.policy && (props.policy.type === CONST.POLICY.TYPE.TEAM || props.policy.type === CONST.POLICY.TYPE.CORPORATE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use PolicyUtils.isPaidGroupPolicy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! We can. I wasn't aware of this util. I'll do a quick change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fixing the lint errors
…t and MoneyTemporaryForRefactorRequestConfirmationList
Please re-test at least on one platform against latest code changes |
@aimane-chnaif I tested on web and it behaved as expected. No longer showing on distance requests or splits and continues to only show on paid policy workspaces. |
Reviewer Checklist
Screenshots/VideosiOS: Nativeios.movMacOS: Chrome / Safariweb-fab-collect.movweb-fab-free.movMacOS: Desktopdesktop-composer+.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
🎯 @aimane-chnaif, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #34901. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.31-7 🚀
|
Details
This PR adds the
ReceiptEmptyState
component to theMoneyRequestConfirmationList
for money requests that are associated with workspace policies of the typeCollect
orControl
.Note: I added the functionality to both the original file as well as the temporary conversion file to maintain consistency.
Fixed Issues
$#27744
PROPOSAL:
Tests
Testing Instructions
Pre-testing instructions:
Collect
orControl
type. Instructions hereExpected flow for Money Request within Paid tier (Collect or Control) Workspaces:
ReceiptEmptyState
component is shown (image below)ReceiptEmptyState
componentExpected flow for Money Request not within Paid tier (Collect or Control) Workspaces:
ReceiptEmptyState
component is not shown (image below)Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android_chrome.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios_safari_480.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop_480.mov