Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag/drop for receipt empty state #27744

Closed
JmillsExpensify opened this issue Sep 19, 2023 · 33 comments
Closed

Add drag/drop for receipt empty state #27744

JmillsExpensify opened this issue Sep 19, 2023 · 33 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@JmillsExpensify
Copy link

JmillsExpensify commented Sep 19, 2023

If a Collect or Control policy is configured with any receipt-related category violation, we’ll update the confirmation screen for manual requests and include a receipt empty state. Tapping the empty state brings up the camera (mobile) or file picker (web). For web, we’ll support drag/drop.

image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e09455d07e462ca6
  • Upwork Job ID: 1704005352336375808
  • Last Price Increase: 2023-09-19
@JmillsExpensify JmillsExpensify added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e09455d07e462ca6

@melvin-bot melvin-bot bot removed the Daily KSv2 label Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2023
@cead22
Copy link
Contributor

cead22 commented Sep 28, 2023

No update from me, focused on detailed design for Wave 9: Violations

@melvin-bot melvin-bot bot removed the Overdue label Sep 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 6, 2023
@JmillsExpensify
Copy link
Author

Still working through the detailed design for Wave 9.

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@JmillsExpensify
Copy link
Author

Still working through the detailed.

@JmillsExpensify
Copy link
Author

Still focused on violations implementation first.

@cead22 cead22 changed the title Add drag/drop for receipt empty state [HOLD App#30663] Add drag/drop for receipt empty state Oct 31, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 2, 2023
@cead22
Copy link
Contributor

cead22 commented Nov 8, 2023

Still on HOLD, but Infinite Red started on App#30663

@melvin-bot melvin-bot bot removed the Overdue label Nov 8, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@cead22 cead22 changed the title [HOLD App#30663] Add drag/drop for receipt empty state Add drag/drop for receipt empty state Nov 22, 2023
@cead22
Copy link
Contributor

cead22 commented Nov 22, 2023

App#30663 is merged so this is off hold. @cdanwards @trevor-coleman can you comment here so I can assign you?

@melvin-bot melvin-bot bot removed the Overdue label Nov 22, 2023
@cdanwards
Copy link
Contributor

Commenting for assignment

@JmillsExpensify
Copy link
Author

Waiting on PR

@JmillsExpensify
Copy link
Author

Still not at the top of the priority list.

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
@cdanwards
Copy link
Contributor

Beginning work on this.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jan 16, 2024
@shawnborton
Copy link
Contributor

One small design bug to fix while we're here:

  • let's update the border color of the thumbnail area to use our colors.border value
  • let's update the background color of the thumbnail area to use our colors.highlightBG value

@cead22
Copy link
Contributor

cead22 commented Jan 25, 2024

@cdanwards please tag @Expensify/design in the PR when you create it

@shawnborton
Copy link
Contributor

Also, the border should not be 2px like it is here:
CleanShot 2024-01-25 at 14 42 36@2x

Just 1px stroke for the border.

@shawnborton
Copy link
Contributor

Also it looks like the image is cut off - I wonder if we need to get you a better image for that? Can you share the image that you are currently using please? Thanks!

@cdanwards
Copy link
Contributor

@shawnborton sorry this got lost in my GH notifications. This one has already been merged, but here is the svg that we're using for this component

@shawnborton
Copy link
Contributor

Interesting, the svg itself seems fine as we can see the borders:
CleanShot 2024-02-05 at 11 55 19@2x

Any idea why it might be getting cut off?

@cdanwards
Copy link
Contributor

@shawnborton I'm honestly not sure. It's the right side that you're referring to, correct? There was some difficulty in having the svg display colors correctly, so that could be part of the issue.

@shawnborton
Copy link
Contributor

Exactly, see how the 1px stroke is slightly cut off?

@cdanwards
Copy link
Contributor

@shawnborton I found the issue. Going to put together a little PR with a fix for that and also the other corrections you mentioned.

@shawnborton
Copy link
Contributor

Amazing, thanks! Feel free to tag me in the PR for review.

@cdanwards
Copy link
Contributor

Screenshot 2024-02-05 at 4 20 38 PM
@shawnborton does this look right for the border width and color you mentioned above? The border looks very faint with the combination of those styles.
I'm using these values:

  backgroundColor: colors.highlightBG,
  borderColor: colors.border,
  borderWidth: 1,

@shawnborton
Copy link
Contributor

I think something is happening here, there is actually no BG color being shown at all. If there was, we wouldn't see the illustration come through.

@cdanwards
Copy link
Contributor

Screenshot 2024-02-05 at 4 26 10 PM
There we are. Got the right values!

@shawnborton
Copy link
Contributor

Much better!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 7, 2024
@JmillsExpensify
Copy link
Author

I believe all the PRs on this issue are merged right? Can we close now?

@cead22
Copy link
Contributor

cead22 commented Feb 9, 2024

Yes! @cdanwards please reopen if I missed anything

@cead22 cead22 closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants