-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all selectors to use new format for selected participant #31648
Conversation
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@dukenv0307 selected options are not listing even if it matches the search term. Kindly check on this. Screen.Recording.2023-11-24.at.3.20.14.PM.mov |
@dukenv0307 Any update on the above? |
@abdulrahuman5196 Sorry for the delay, I don't know how I missed noti for this, checking on this now |
@abdulrahuman5196 A question here: If we search for a new user which will be |
Hi @dukenv0307 |
@dukenv0307 Ping on the above? Could you kindly fix and let me know once the PR is ready for review. |
@abdulrahuman5196 The logic for getting the participants section is updated by the Internal team and it differs from the logic when I submit the proposal |
The code was updated to fix the above issue. Kindly review it again. |
Sure. Let me check in my morning. |
@abdulrahuman5196 Friendly bump. Please help review this PR again |
Hi, Sorry for the delay will review today. |
reviewing now |
@@ -93,13 +93,22 @@ function RoomInvitePage(props) { | |||
const sections = []; | |||
let indexOffset = 0; | |||
|
|||
// Filter all options that is a part of the search term or in the personal details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filter should only happen when we have searchTerm.
For reference: https://github.com/Expensify/App/blob/main/src/libs/OptionsListUtils.js#L1697
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdulrahuman5196
if we do not have searchTerm, then we gonna show the list of options from personalDetailsList, so I think this logic is correct.
Let me know if any concerns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point you made is correct. But what I am suggesting is an optimization. Like when there is no searchTerm, we will always get the whole list. So it becomes a wasteful search(Correct me if wrong).
So we can filter only when we have a searchTerm,
like the below pseudo code
const filterSelectedOptions = selectedOptions
if searchTerm != '' {
filterSelectedOptions = filter()
}
@@ -135,13 +135,22 @@ function WorkspaceInvitePage(props) { | |||
const sections = []; | |||
let indexOffset = 0; | |||
|
|||
// Filter all options that is a part of the search term or in the personal details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dukenv0307 Kindly check on the requested changes
@abdulrahuman5196 Updated. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-12-28.at.9.15.20.PM.mp4Android: mWeb ChromeScreen.Recording.2023-12-28.at.9.19.44.PM.mp4iOS: NativeScreen.Recording.2023-12-28.at.8.59.54.PM.mp4iOS: mWeb SafariScreen.Recording.2023-12-28.at.9.06.56.PM.mp4MacOS: Chrome / SafariScreen.Recording.2023-12-28.at.8.12.27.PM.mp4MacOS: DesktopScreen.Recording.2023-12-28.at.8.56.32.PM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @thienlnam
🎀 👀 🎀
C+ Reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.21-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀
|
Details
Update all selectors to use a new format for selected participant
Fixed Issues
$ #29916
PROPOSAL: #29916 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android-resize.mov
Android: mWeb Chrome
chrome-resize.mov
iOS: Native
ios-resize.mov
iOS: mWeb Safari
safari-resize.mov
MacOS: Chrome / Safari
web-resize.mov
MacOS: Desktop
desktop-resize.mov