[HOLD for payment 2024-01-22] [$500] Workspace - In Workspace, trying to add a number contact & selecting it, contact disappears

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Tap Profile icon
3. Tap Workspaces ---- Workspace ---- Members
4. Tap invite
5. Enter a number eg: +919787766754
6. From the list, tap and select the contact

Expected Result:

In Workspace, trying to add a number contact & selecting it, contact must not disappear

Actual Result:

In Workspace, trying to add a number contact & selecting it, contact disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333021_1704448239114.ws.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012bf34b264efa7a44
• Upwork Job ID: 1743245225212407808
• Last Price Increase: 2024-01-05
• Automatic offers:
• abdulrahuman5196 | Contributor | 28087732
• dukenv0307 | Contributor | 28087733

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012bf34b264efa7a44

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[dukenv0307]

This is regression from my PR here

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Workspace, trying to add a number contact & selecting it, contact disappears

What is the root cause of that problem?

We don't trim and replace all spaces in option.text here

App/src/pages/workspace/WorkspaceInvitePage.js

Line 145 in 7ae1ec7

const isPartOfSearchTerm = option.text.toLowerCase().includes(searchTerm.trim().toLowerCase());

before comparing

What changes do you think we should make in order to solve the problem?

trim and replace all spaces in option.text here

App/src/pages/workspace/WorkspaceInvitePage.js

Line 145 in 7ae1ec7

const isPartOfSearchTerm = option.text.toLowerCase().includes(searchTerm.trim().toLowerCase());

before comparing

What alternative solutions did you explore? (Optional)

NA

[unidev727]

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

Workspace - In Workspace, trying to add a number contact & selecting it, contact disappears

What is the root cause of that problem?

The root cause is that option.text has spaces so that it different from search term here.

App/src/pages/workspace/WorkspaceInvitePage.js

Line 145 in 7ae1ec7

const isPartOfSearchTerm = option.text.toLowerCase().includes(searchTerm.trim().toLowerCase());

What changes do you think we should make in order to solve the problem?

We should use option.login instead of option.text here.

App/src/pages/workspace/WorkspaceInvitePage.js

Line 145 in 7ae1ec7

const isPartOfSearchTerm = option.text.toLowerCase().includes(searchTerm.trim().toLowerCase());

to

const isPartOfSearchTerm = option.login.toLowerCase().includes(searchTerm.trim().toLowerCase());

What alternative solutions did you explore?

N/A

[paultsimura]

This is a regression from #31648, which is still within the regression period.

Confirmed by reverting the PR locally:

cc: @abdulrahuman5196 @thienlnam

[thienlnam]

Thanks Pavlo - assigning from that PR

[dukenv0307]

@paultsimura this PR is ready for preview.

[abdulrahuman5196]

Hi, Thanks for the PR. It seems this is not a deploy blocker. So Will work on review in my morning.

[kevinksullivan]

Hi @abdulrahuman5196 any update?

[abdulrahuman5196]

@kevinksullivan the PR was merged. Since this is a regression issue, we can close the issue once we verify in production after it reaches there.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Replace all spaces before compare with search text in workspace invite #34083

If no regressions arise, payment will be issued on 2024-01-22. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

No payments for this regression issue.

[abdulrahuman5196]

the PR was merged. Since this is a regression issue, we can close the issue once we verify in production after it reaches there.

Yeah. Already pointed out here. We can close this issue.