Reveal card details error handling #31067

lukemorawski · 2023-11-08T16:28:16Z

Details

The aim of this PR is to add error handling to the "Reveal Details" action for the Card Details Page.
This is done by returning a generic message taken from localisation files and passing it upon promise rejection.
This message then is caught in the Card Details page and displayed by DotIndicator component.
If the next attempt is successful the message is clear out.

Fixed Issues

$ #30329
PROPOSAL: no proposal

Tests

Same as QA tests

Verify that no errors appear in the JS console

Offline tests

Same as QA tests

QA Steps

open this address in the browser https://dev.new.expensify.com:8082/settings/wallet/card/expensify
"Not Found" page should show if the card is non-existant
execute this code in the console:

Onyx.merge(`cardList`, {
            5678: {
            cardID: 5678,
            state: 4,
            bank: '1000',
            availableSpend: 10000,
            domainName: 'expensify',
            lastFourPAN: '2345',
            isVirtual: true,
            },
        });

a card page should show up with the fake card
tap "Reveal Detail' - an error will occur
Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

no native screenshot as it's hard to modify Onyx and create a fake card here but it there is no reason why it should not work here

Android: mWeb Chrome

iOS: Native

no native screenshot as it's hard to modify Onyx and create a fake card here but it there is no reason why it should not work here

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

src/pages/settings/Wallet/ExpensifyCardPage.js

Co-authored-by: VickyStash <vikstash@gmail.com>

src/pages/settings/Wallet/ExpensifyCardPage.js

rezkiy37

Left a minor comment, besides LGTM.

Co-authored-by: Michael (Mykhailo) Kravchenko <rezkiy37@gmail.com>

melvin-bot · 2023-11-09T10:21:49Z

@dubielzyk-expensify @allroundexperts One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dylanexpensify · 2023-11-09T18:27:38Z

@dubielzyk-expensify @allroundexperts can one of you complete reviewer checklist, please 🙇‍♂️

allroundexperts · 2023-11-09T18:30:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-10.at.12.11.21.AM.mov

Android: mWeb Chrome

Screen.Recording.2023-11-10.at.12.08.23.AM.mov

iOS: Native

Screen.Recording.2023-11-10.at.12.13.17.AM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-10.at.12.08.23.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-09.at.11.57.13.PM.mov

MacOS: Desktop

Screen.Recording.2023-11-10.at.12.01.19.AM.mov

allroundexperts · 2023-11-09T18:56:29Z

BUG

Screen.Recording.2023-11-09.at.11.48.10.PM.mov

allroundexperts · 2023-11-09T18:58:15Z

Also, @dylanexpensify Can you please confirm if we don't need the x to hide the error message?

allroundexperts · 2023-11-09T19:16:34Z

src/pages/settings/Wallet/ExpensifyCardPage.js

+                                                <DotIndicatorMessage
+                                                    messages={cardDetailsErrorObject}
+                                                    type="error"
+                                                    style={styles.ph5}


This is culprit of the crash I commented about earlier. This should be an array instead.

allroundexperts

A small change needed.

lukemorawski · 2023-11-13T10:18:59Z

@allroundexperts fixed

allroundexperts

Looks good!

grgia · 2023-11-13T12:42:05Z

Author checklist check was not working, merged

OSBotify · 2023-11-13T12:47:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-14T22:10:45Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T20:54:01Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T21:09:27Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

lukemorawski added 3 commits November 6, 2023 10:59

error handling

489cddc

spanish translation

b44a43a

prettier

bf35c29

pasyukevich reviewed Nov 8, 2023

View reviewed changes

src/pages/settings/Wallet/ExpensifyCardPage.js Outdated Show resolved Hide resolved

VickyStash reviewed Nov 8, 2023

View reviewed changes

src/pages/settings/Wallet/ExpensifyCardPage.js Outdated Show resolved Hide resolved

src/pages/settings/Wallet/ExpensifyCardPage.js Show resolved Hide resolved

lukemorawski and others added 2 commits November 8, 2023 17:47

remove unnecessary brackets

99a2338

Co-authored-by: VickyStash <vikstash@gmail.com>

remove unnecessary brackets

c15318c

Co-authored-by: VickyStash <vikstash@gmail.com>

rezkiy37 reviewed Nov 8, 2023

View reviewed changes

src/pages/settings/Wallet/ExpensifyCardPage.js Outdated Show resolved Hide resolved

rezkiy37 approved these changes Nov 8, 2023

View reviewed changes

lukemorawski and others added 2 commits November 9, 2023 10:24

param name change

cb30907

Co-authored-by: Michael (Mykhailo) Kravchenko <rezkiy37@gmail.com>

removed duplicated card details section

8b3d875

lukemorawski marked this pull request as ready for review November 9, 2023 10:21

lukemorawski requested a review from a team as a code owner November 9, 2023 10:21

melvin-bot bot requested review from allroundexperts and dubielzyk-expensify and removed request for a team November 9, 2023 10:21

allroundexperts reviewed Nov 9, 2023

View reviewed changes

allroundexperts suggested changes Nov 9, 2023

View reviewed changes

dubielzyk-expensify previously approved these changes Nov 12, 2023

View reviewed changes

bug fix

7bd2411

lukemorawski dismissed dubielzyk-expensify’s stale review via 7bd2411 November 13, 2023 10:18

allroundexperts approved these changes Nov 13, 2023

View reviewed changes

melvin-bot bot requested a review from grgia November 13, 2023 10:21

grgia approved these changes Nov 13, 2023

View reviewed changes

grgia merged commit b867619 into Expensify:main Nov 13, 2023

OSBotify mentioned this pull request Nov 14, 2023

Deploy Checklist: New Expensify 2023-11-14 #31324

Closed

melvin-bot bot mentioned this pull request Nov 15, 2023

[HOLD for payment 2023-11-22] [ECARD] CRITICAL: Settings - Reveal Details Follow Up - Add Error Handling #30329

Closed

OSBotify mentioned this pull request Nov 15, 2023

Deploy Checklist: New Expensify 2023-11-15 #31404

Closed

37 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reveal card details error handling #31067

Reveal card details error handling #31067

lukemorawski commented Nov 8, 2023

rezkiy37 left a comment

melvin-bot bot commented Nov 9, 2023

dylanexpensify commented Nov 9, 2023

allroundexperts commented Nov 9, 2023 •

edited

Loading

allroundexperts commented Nov 9, 2023

allroundexperts commented Nov 9, 2023

allroundexperts Nov 9, 2023

allroundexperts left a comment

lukemorawski commented Nov 13, 2023

allroundexperts left a comment

grgia commented Nov 13, 2023

OSBotify commented Nov 13, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

OSBotify commented Nov 15, 2023

Reveal card details error handling #31067

Reveal card details error handling #31067

Conversation

lukemorawski commented Nov 8, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 9, 2023

dylanexpensify commented Nov 9, 2023

allroundexperts commented Nov 9, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Nov 9, 2023

allroundexperts commented Nov 9, 2023

allroundexperts Nov 9, 2023

Choose a reason for hiding this comment

allroundexperts left a comment

Choose a reason for hiding this comment

lukemorawski commented Nov 13, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

grgia commented Nov 13, 2023

OSBotify commented Nov 13, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

OSBotify commented Nov 15, 2023

allroundexperts commented Nov 9, 2023 •

edited

Loading