Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-11-15 #31404

Closed
37 tasks done
OSBotify opened this issue Nov 15, 2023 · 19 comments
Closed
37 tasks done

Deploy Checklist: New Expensify 2023-11-15 #31404

OSBotify opened this issue Nov 15, 2023 · 19 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Nov 15, 2023

Release Version: 1.4.0-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Nov 15, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.0-0 🚀

@kavimuru
Copy link

Regression is 95% completed.

#31029 failing with blocker #31407

@kavimuru
Copy link

Regression is completed.

Unchecked PR:
#31029 failing with blocker #31407

Open blockers:
#31407
#31413
#31418
#31426
#31431
#31434

@roryabraham
Copy link
Contributor

#31407 and #31418 should be fixed by #31420 in 1.4.0-1. Can we retest please?

@kavimuru
Copy link

kavimuru commented Nov 16, 2023

@roryabraham yes. Will retest and update shortly. Should we retest in all the platforms?
FYI : #31420 is a pass.

@kavimuru
Copy link

Both the issues are fixed

@roryabraham
Copy link
Contributor

#31426 should be fixed by #31457 in 1.4.0-3. @kavimuru can you retest once the build is available?

@kavimuru
Copy link

@roryabraham our QA team is validating. Will update once it is done.

@kavimuru
Copy link

android and mweb - android are pass. iOS build is not updated to 1.4.0-3

@roryabraham
Copy link
Contributor

Demoting #31413 and checking it off

@roryabraham
Copy link
Contributor

#31431 should be fixed by #31454 in 1.4.0-2.

@kavimuru can you please retest?

@kavimuru
Copy link

@roryabraham We validated the cp and already checked off the list

@roryabraham
Copy link
Contributor

It's not checked off, but I'll do that now

@kavimuru
Copy link

Sorry, I meant the CP in the list. Not the Deploy Blocker list.

@Julesssss
Copy link
Contributor

I'm checking off #31542 as it currently exists on main. We'll need to add it as a blocker once this checklist is deployed.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Nov 20, 2023
@mountiny
Copy link
Contributor

Github status, graphs and crashlytics all seems good

@mountiny
Copy link
Contributor

Last deploy blocker removed! I will go ahead with the deploy so we can get on with the QA as fast as possible.

@mountiny
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants