Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chats show as bold and unread in LHN when sending a message #31463

Closed
2 of 6 tasks
m-natarajan opened this issue Nov 16, 2023 · 27 comments
Closed
2 of 6 tasks

Chats show as bold and unread in LHN when sending a message #31463

m-natarajan opened this issue Nov 16, 2023 · 27 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@m-natarajan
Copy link

m-natarajan commented Nov 16, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.0-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1700177279688189

Action Performed:

  1. Open app and login as account A
  2. Open a report of account B
  3. Send a message
  4. Observe the LHN

Expected Result:

LHN should not be bold for account A

Actual Result:

Chat in LHN shows bold, even though I'm the one who sent the most recent message

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.241.mp4

image (1)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fcba9af5589f5538
  • Upwork Job ID: 1735254863746113536
  • Last Price Increase: 2023-12-14
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 16, 2023
Copy link

melvin-bot bot commented Nov 16, 2023

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Nov 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 16, 2023

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@DylanDylann
Copy link
Contributor

Can't reproduce

@mallenexpensify
Copy link
Contributor

Here's a vid, in case it's helpful

2023-11-16_16-55-16.mp4

@ikevin127
Copy link
Contributor

Possible duplicates of

Quoted from #31276

I think that this issue is a possible duplicate of #28536, or at least has a high chance of getting solved by the associated PR

To be sure, given the video above, when clicking to Scott Deeter, try clicking back to mallen fail - if it becomes read then that's confirmation it's a duplicate of the ones mentioned above.

@mkhutornyi
Copy link
Contributor

This is regression from staging backend. Not frontend issue.
cc: @MonilBhavsar as you're managing this kind of issues

@MonilBhavsar
Copy link
Contributor

Yes, co assigning and taking a look

@MonilBhavsar MonilBhavsar self-assigned this Nov 17, 2023
@MonilBhavsar
Copy link
Contributor

Confirmed it's regression from staging server 👍

@MonilBhavsar MonilBhavsar removed the DeployBlockerCash This issue or pull request should block deployment label Nov 17, 2023
@MonilBhavsar
Copy link
Contributor

Issue created internally for blocking deploy https://github.com/Expensify/Expensify/issues/337349
Closing this one

@MonilBhavsar
Copy link
Contributor

This issue is fixed!

@izarutskaya
Copy link

izarutskaya commented Dec 7, 2023

Issue is reproducible again
build 1.4.9-2

RPReplay_Final1701908773.MP4

@izarutskaya izarutskaya reopened this Dec 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 7, 2023
@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Dec 7, 2023

This does seem like issue when receiving messages? Can we please get steps to repro and is it only happening on iOS/mobile. Also is it happening on staging and not on production?

@chiragsalian chiragsalian removed their assignment Dec 7, 2023
@chiragsalian chiragsalian added Daily KSv2 and removed Hourly KSv2 labels Dec 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

@sonialiap, @MonilBhavsar Whoops! This issue is 2 days overdue. Let's get this updated quick!

@sonialiap
Copy link
Contributor

@izarutskaya a few questions

  1. Which platform is it happening on, only on iOS/mobile or web and android too?
  2. Is it happening on staging and not on production?
  3. What steps did you take to reproduce this issue? The same ones as in the original posit? I.e.
  1. Open app and login as account A
  2. Open a report of account B
  3. Send a message
  4. Observe the LHN

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2023
Copy link

melvin-bot bot commented Dec 14, 2023

@sonialiap @MonilBhavsar this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff Overdue labels Dec 14, 2023
Copy link

melvin-bot bot commented Dec 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01fcba9af5589f5538

Copy link

melvin-bot bot commented Dec 14, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (Internal)

@melvin-bot melvin-bot bot removed the Overdue label Dec 14, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

@sonialiap, @jjcoffee, @MonilBhavsar Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@MonilBhavsar
Copy link
Contributor

I am using newDot a lot and haven't experienced this bug. @sonialiap are you experiencing this bug or able to reproduce?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 18, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

@sonialiap, @jjcoffee, @MonilBhavsar Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MonilBhavsar
Copy link
Contributor

I haven't reproduced this issue while using new expensify daily. Feel free to reopen if you experience this issue

@lanitochka17
Copy link

Issue is reproducible again (IOS)
Build 1.4.21-1

RPReplay_Final1704293674.mp4

@lanitochka17 lanitochka17 reopened this Jan 3, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 3, 2024
@MonilBhavsar
Copy link
Contributor

@lanitochka17 this seems like different issue where message is marked as unread when received from different user.
Current Github issue is when message is marked as unread when sending a message. Looks like in the video no message was sent and only received. Can you please create different issue to keep conversation and findings separate. Please assign it to me. I am happy to take a look.

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
@MonilBhavsar
Copy link
Contributor

closing in favour of #33974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests