-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download E.cash attachments immediately #3066
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
50 changes: 50 additions & 0 deletions
50
src/components/AnchorForCommentsOnly/AnchorWithAuthToken.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import _ from 'underscore'; | ||
import React from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import {withOnyx} from 'react-native-onyx'; | ||
import ONYXKEYS from '../../ONYXKEYS'; | ||
import { | ||
propTypes as anchorForCommentsOnlyPropTypes, | ||
defaultProps as anchorForCommentsOnlyDefaultProps, | ||
} from './anchorForCommentsOnlyPropTypes'; | ||
import BaseAnchorForCommentsOnly from './BaseAnchorForCommentsOnly'; | ||
import addAuthTokenToURL from '../../libs/addAuthTokenToURL'; | ||
|
||
const propTypes = { | ||
/** Session info for the currently logged in user. */ | ||
session: PropTypes.shape({ | ||
/** Currently logged in user authToken */ | ||
authToken: PropTypes.string, | ||
}), | ||
|
||
...anchorForCommentsOnlyPropTypes, | ||
}; | ||
|
||
const defaultProps = { | ||
session: { | ||
authToken: null, | ||
}, | ||
...anchorForCommentsOnlyDefaultProps, | ||
}; | ||
|
||
const AnchorWithAuthToken = (props) => { | ||
const urlWithAuthToken = addAuthTokenToURL({ | ||
url: props.href, | ||
authToken: props.session.authToken, | ||
}); | ||
const propsToPass = _.omit(props, 'session'); | ||
propsToPass.href = urlWithAuthToken; | ||
propsToPass.shouldDownloadFile = true; | ||
// eslint-disable-next-line react/jsx-props-no-spreading | ||
return <BaseAnchorForCommentsOnly {...propsToPass} />; | ||
}; | ||
|
||
AnchorWithAuthToken.propTypes = propTypes; | ||
AnchorWithAuthToken.defaultProps = defaultProps; | ||
AnchorWithAuthToken.displayName = 'AnchorWithAuthToken'; | ||
|
||
export default withOnyx({ | ||
session: { | ||
key: ONYXKEYS.SESSION, | ||
}, | ||
})(AnchorWithAuthToken); |
33 changes: 33 additions & 0 deletions
33
src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import React from 'react'; | ||
import {StyleSheet, Text} from 'react-native'; | ||
import {propTypes, defaultProps} from '../anchorForCommentsOnlyPropTypes'; | ||
|
||
/* | ||
* This is a default anchor component for regular links. | ||
*/ | ||
const BaseAnchorForCommentsOnly = ({ | ||
href, | ||
rel, | ||
target, | ||
children, | ||
style, | ||
...props | ||
}) => ( | ||
<Text | ||
style={StyleSheet.flatten(style)} | ||
accessibilityRole="link" | ||
href={href} | ||
rel={rel} | ||
target={target} | ||
// eslint-disable-next-line react/jsx-props-no-spreading | ||
{...props} | ||
> | ||
{children} | ||
</Text> | ||
); | ||
|
||
BaseAnchorForCommentsOnly.propTypes = propTypes; | ||
BaseAnchorForCommentsOnly.defaultProps = defaultProps; | ||
BaseAnchorForCommentsOnly.displayName = 'BaseAnchorForCommentsOnly'; | ||
|
||
export default BaseAnchorForCommentsOnly; | ||
joelbettner marked this conversation as resolved.
Show resolved
Hide resolved
|
30 changes: 30 additions & 0 deletions
30
src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly/index.native.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import React from 'react'; | ||
import {Linking, StyleSheet, Text} from 'react-native'; | ||
import {propTypes, defaultProps} from '../anchorForCommentsOnlyPropTypes'; | ||
import fileDownload from '../../../libs/fileDownload'; | ||
|
||
/* | ||
* This is a default anchor component for regular links. | ||
*/ | ||
const BaseAnchorForCommentsOnly = ({ | ||
href, | ||
children, | ||
style, | ||
shouldDownloadFile, | ||
...props | ||
}) => ( | ||
<Text | ||
style={StyleSheet.flatten(style)} | ||
onPress={() => (shouldDownloadFile ? fileDownload(href) : Linking.openURL(href))} | ||
// eslint-disable-next-line react/jsx-props-no-spreading | ||
{...props} | ||
> | ||
{children} | ||
</Text> | ||
); | ||
|
||
BaseAnchorForCommentsOnly.propTypes = propTypes; | ||
BaseAnchorForCommentsOnly.defaultProps = defaultProps; | ||
BaseAnchorForCommentsOnly.displayName = 'BaseAnchorForCommentsOnly'; | ||
|
||
export default BaseAnchorForCommentsOnly; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this include the
shouldDownloadFile
prop since it is being passed fromAnchorWithAuthToken.js
. If it is not necessary to haveshouldDownloadFile
here because it is passed in...props
, then is it redundant when we haveshouldDownloadFile
in the props forBaseAnchorForCommentsOnly/index.native.js
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good question.
It's not necessary because it's not being used in this file. It is passed to the nested
Text
in...props
, but because theText
doesn't take ashouldDownloadFile
prop it just has no effect.It's not redundant, because the
shouldDownloadFile
prop is used to determineonPress
prop of theText
component inBaseAnchorForCommentsOnly/index.native.js
. Then it's also passed to theText
component as part of...props
, but like the web implementation just has no effect.