Download E.cash attachments immediately

[roryabraham]

Details

Passes an auth token in the chat attachment URL, if necessary.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/154254

Tests / QA Steps

1. Send a regular link such as https://www.google.com/ in Expensify.cash
2. Click on the link, ensure that it is opened in the default browser.
3. Click on Upload Attachment and upload a .zip file.
4. After a few moments, a link to that attachment should appear.
5. Click on that link, and ensure that the file is downloaded immediately. You should not have to log in to the expensify.com website.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

DownloadAttachmentMWeb.mov

Mobile Web

DownloadAttachmentMWeb.mov

Desktop

DownloadAttachmentsDesktop.mov

iOS

DownloadAttachmentiOS.mov

Android

[roryabraham]

This needs to be on HOLD until https://github.com/Expensify/Web-Expensify/pull/31009 is merged and deployed to production.

[roryabraham]

https://github.com/Expensify/Web-Expensify/pull/31009 was deployed to prod yesterday, so this is ready for review 👍

[joelbettner]

Should this include the shouldDownloadFile prop since it is being passed from AnchorWithAuthToken.js . If it is not necessary to have shouldDownloadFile here because it is passed in ...props, then is it redundant when we have shouldDownloadFile in the props for BaseAnchorForCommentsOnly/index.native.js ?

[roryabraham]

This is a good question.

Should this include the shouldDownloadFile prop since it is being passed from AnchorWithAuthToken.js

It's not necessary because it's not being used in this file. It is passed to the nested Text in ...props, but because the Text doesn't take a shouldDownloadFile prop it just has no effect.

is it redundant when we have shouldDownloadFile in the props for BaseAnchorForCommentsOnly/index.native.js

It's not redundant, because the shouldDownloadFile prop is used to determine onPress prop of the Text component in BaseAnchorForCommentsOnly/index.native.js. Then it's also passed to the Text component as part of ...props, but like the web implementation just has no effect.

[joelbettner]

LGTM

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.