Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-adding AutoAssignerTriage label to new issues #2853

Merged
merged 2 commits into from
May 13, 2021

Conversation

Beamanator
Copy link
Contributor

Details

name: and about: front-matter need to be added (and not empty) in ISSUE_TEMPLATE.md to make label-adding work.

I found this text in Github Documentation:

To be included in the community profile checklist, issue templates must be located in the .github/ISSUE_TEMPLATE folder and contain valid name: and about: YAML front matter.

I tried setting empty name: and about: values in my personal repo here, but you can clearly the error stating these values cannot be empty:

Screen Shot 2021-05-13 at 11 01 59 AM

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/163447

Tests

Once merged, try creating a new issue in this repo & notice if AutoAssignerTriage was automatically added to the issue. You shouldn't have to create the issue to see the label, you just have to click "New Issue" and the label should be added.

QA Steps

See above

Tested On

  • Github (my personal repo)

Screenshots

N/A

@Beamanator Beamanator requested a review from a team as a code owner May 13, 2021 09:15
@Beamanator Beamanator self-assigned this May 13, 2021
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team May 13, 2021 09:16
@Beamanator Beamanator changed the title Attempt to fix auto-add label to new issues Fix auto-adding AutoAssignerTriage label to new issues May 13, 2021
Comment on lines +2 to +3
name: Standard issue template
about: A standard template to follow when creating an issue in this repository
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: These fields may show up if we ever decide to create multiple issue templates for this repo, so feel free to suggest different text here if you think it can be improved :)

Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NikkiWines NikkiWines merged commit c20510a into main May 13, 2021
@NikkiWines NikkiWines deleted the beaman-fix-adding-AutoAssignerTriage-to-new-issues branch May 13, 2021 17:35
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.43-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham
Copy link
Contributor

@Beamanator This didn't seem to work #2861

@Beamanator
Copy link
Contributor Author

Good call - another fix incoming 🤷

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants