Deploy Checklist: Expensify.cash 2021-05-08

[OSBotify]

Release Version: 1.0.44-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix flashing messages on iOS #2252
• Edit Comments #2320
• fixed modal animations #2680
• Improve Chat Switch timing in Grafana so it waits for all messages to layout #2684
• Allow menus to be dynamically positioned. #2706
• Apply localization to all hard coded text #2718
• Viacheslav first names #2724
• Place the new marker when a chat becomes visible #2737
• Logic to support closed account receiving a link to set password and for unvalidated and closed accounts to get the email the moment they log into ecash #2745
• Refactor modal stack navigators #2765
• Update expensify-common hash #2766
• [No QA] Fix parsing bug in getStagingDeployCash #2771
• Update CONTRIBUTING.md #2773
• Implement more flexible regex parsing of StagingDeployCash issues #2776
• Return early if no valid sequenceNumber can be found #2777
• Add ability to get the current operating system, display subset of emojis if on Windows #2787
• Use debounce for onDimensionChange in withWindowDimensions HOC #2799
• Make sure withLocalize forwards its ref #2800
• Set openByDefault prop only for small screen width #2814
• fixed text-wrapping with Markup #2826
• Revert "fixed modal animations" #2833
• Revert "Exclude concierge from iou" #2834
• Fix auto-adding AutoAssignerTriage label to new issues #2853
• Make sure we show the compose box on login #2860
• Dummy Markdown change #2867
• Revert "Readme change for testing deploy" #2893
• Remove incorrect === from deploy.yml #2896

Deploy Blockers:

• Edit Comments #2320
• Blank white screen and console error after signing in and loading reports screen #2785
• focus and blur aren't callable when refs are passed into TextInputFocusable #2786
• [Pay 5/19] Wrap text when it includes markup #2790
• Chat - Compose box doesn't appear after fresh installing the app #2804
• New group - App crashes when initiating chat with newly created group #2809
• [iOS] Infinite loading spinners when trying to launch anything from the CreateMenu #2825
• Chat - App crashes after sending few messages #2842
• Chat - Sent images are not displayed in chat  #2844

cc @Expensify/applauseleads

[roryabraham]

Manually added the following PRs that were missing from this list:

• Improve Chat Switch timing in Grafana so it waits for all messages to layout #2684
• Allow menus to be dynamically positioned. #2706
• Apply localization to all hard coded text #2718

[isagoico]

Starting QA

[isagoico]

Regression is finished!
3 Issues found today:

1. Timezone - Dropdown is selectable when the "Set my time zone" bottom checkbox is checked #2806
2. Chat - Compose box doesn't appear after fresh installing the app #2804
3. New group - App crashes when initiating chat with newly created group #2809

PRs are finished too:
2 comments added:

1. Allow menus to be dynamically positioned. #2706 (comment)
2. Edit Comments #2320 (comment) - Not a deploy blocker.

Thanks!

[isagoico]

@roryabraham Heyo! I'll be adding the lock label in ~40min. Are there any PRs that were not added to the list that need to be manually added?

[roryabraham]

Nope, it should be back to normal now ☺️

[isagoico]

Starting QA

[isagoico]

Regression is finished!
4 issues found today.

1. Chat - Two New messages line displayed on one conversation #2849
2. Chat - Sent images are not displayed in chat  #2844
3. Chat - App crashes after sending few messages #2842
4. Edit box - Text scroller appears if the edited text contains a emoji #2850

PRs are finished too.
Some PRs were not tested on Desktop app yet (because the build failed to deploy) but will be tested tomorrow during QA.

Thanks!

[roryabraham]

Adding Lock label as part of testing here

[roryabraham]

Okay, we made it to step 15 of the testing plan here, so here's a snapshot of the current state of this issue:

Current `StagingDeployCash` issue body

**Release Version:** `1.0.44-0`
**Compare Changes:** https://github.com/Expensify/Expensify.cash/compare/production...staging

**This release contains changes from the following pull requests:**
- [x] https://github.com/Expensify/Expensify.cash/pull/2252
- [x] https://github.com/Expensify/Expensify.cash/pull/2320
- [x] https://github.com/Expensify/Expensify.cash/pull/2680
- [x] https://github.com/Expensify/Expensify.cash/pull/2684
- [x] https://github.com/Expensify/Expensify.cash/pull/2706
- [x] https://github.com/Expensify/Expensify.cash/pull/2718
- [ ] https://github.com/Expensify/Expensify.cash/pull/2724
- [x] https://github.com/Expensify/Expensify.cash/pull/2737
- [ ] https://github.com/Expensify/Expensify.cash/pull/2745
- [x] https://github.com/Expensify/Expensify.cash/pull/2765
- [x] https://github.com/Expensify/Expensify.cash/pull/2766
- [x] https://github.com/Expensify/Expensify.cash/pull/2771
- [x] https://github.com/Expensify/Expensify.cash/pull/2773
- [x] https://github.com/Expensify/Expensify.cash/pull/2776
- [x] https://github.com/Expensify/Expensify.cash/pull/2777
- [x] https://github.com/Expensify/Expensify.cash/pull/2787
- [ ] https://github.com/Expensify/Expensify.cash/pull/2799
- [x] https://github.com/Expensify/Expensify.cash/pull/2800
- [x] https://github.com/Expensify/Expensify.cash/pull/2814
- [x] https://github.com/Expensify/Expensify.cash/pull/2826
- [x] https://github.com/Expensify/Expensify.cash/pull/2833
- [x] https://github.com/Expensify/Expensify.cash/pull/2834
- [x] https://github.com/Expensify/Expensify.cash/pull/2853
- [ ] https://github.com/Expensify/Expensify.cash/pull/2860
- [ ] https://github.com/Expensify/Expensify.cash/pull/2867
- [ ] https://github.com/Expensify/Expensify.cash/pull/2893
- [ ] https://github.com/Expensify/Expensify.cash/pull/2896

**Deploy Blockers:**
- [x] https://github.com/Expensify/Expensify.cash/pull/2320
- [x] https://github.com/Expensify/Expensify.cash/issues/2785
- [x] https://github.com/Expensify/Expensify.cash/issues/2786
- [x] https://github.com/Expensify/Expensify.cash/issues/2790
- [ ] https://github.com/Expensify/Expensify.cash/issues/2804
- [x] https://github.com/Expensify/Expensify.cash/issues/2809
- [x] https://github.com/Expensify/Expensify.cash/issues/2825
- [ ] https://github.com/Expensify/Expensify.cash/issues/2842
- [ ] https://github.com/Expensify/Expensify.cash/issues/2844

cc @Expensify/applauseleads

So, next I'm going to check off all the remaining items and run a production deploy.

[roryabraham]