Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expensify-common hash #2766

Merged
merged 1 commit into from
May 10, 2021
Merged

Update expensify-common hash #2766

merged 1 commit into from
May 10, 2021

Conversation

alex-mechler
Copy link
Contributor

Details

Hash update for Expensify/expensify-common#366

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/153365

Tests / QA Steps

  1. Send the following message
[test i hate it ‘’“”](google.com)
[this referral from form-submission@squarespace.info](https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%22096cf117d50000593e66905000000001%22)+AND+timestamp:[2021-04-13T12:07:25.341Z+TO+2021-04-13T14:07:25.341Z]&index=logs_expensify-010181)
  1. Verify it properly links
    image

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

image

@alex-mechler alex-mechler requested a review from a team May 10, 2021 19:53
@alex-mechler alex-mechler self-assigned this May 10, 2021
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team May 10, 2021 19:54
@nickmurray47 nickmurray47 merged commit 4293521 into main May 10, 2021
@nickmurray47 nickmurray47 deleted the amechler-expensify-common-hash branch May 10, 2021 21:51
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.41-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham mentioned this pull request May 11, 2021
Closed
36 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmurray47 nickmurray47 nickmurray47 approved these changes

Assignees

@alex-mechler alex-mechler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-mechler @OSBotify @nickmurray47