Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating workspace reimburse view #22172

Closed
wants to merge 6 commits into from
Closed

Migrating workspace reimburse view #22172

wants to merge 6 commits into from

Conversation

KrAbhas
Copy link
Contributor

@KrAbhas KrAbhas commented Jul 4, 2023 •
edited
Loading

Details

Fixed Issues

$ 16312
PROPOSAL: GH_LINK_ISSUE(COMMENT) 1608137455

Tests

  1. Open expenxify, click on avatar, settings panel will open
  2. Go to Workspace, create workspace if already not present, click reimbursements
  3. The panel that opens is our component 'WorkspaceReimburseView'
  4. Click on on all the cards and links to make sure it is working.
  5. The first panel titled 'Capture Receipts' should open up a link in new tab for expenses (link will not find a page in localhost)
  6. The second panel titled Track distance that will open up another page where one can configure values changing which will reflect in our component's second panel.
  7. Third panel is a connect bank account that opens a different component with a card for streamlined payments.
  8. The component gets synced going from offline to online.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
WorkspaceReimburseView_web.mov
Mobile Web - Chrome
WorkspaceReimburse_android_chrome.mp4
Mobile Web - Safari
WorkspaceReimburse_ios_safari_720p.mov
Desktop
WorkspaceReimburse_desktop_720p.mov
iOS
WorkspaceReimburseView_ios_720p.mov
Android
WorkspaceReimburseView_android_480p.mov

@abhasadsk
migrate workspaceReimburseView.js
178517e
@abhasadsk
Refactor, improve reconnecting logic and useEffect
5d67273 
Moved variable declaration to top of component
Add and use custom hook for reconnecting logic
Refactor and combine useEffect adding required depedencies
@KrAbhas KrAbhas requested a review from a team as a code owner July 4, 2023 12:55
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023 •
edited
Loading

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ @KrAbhas
❌ @abhas Kumar
Abhas Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team July 4, 2023 12:55
@melvin-bot
Copy link

melvin-bot bot commented Jul 4, 2023

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@KrAbhas
Copy link
Contributor Author

KrAbhas commented Jul 4, 2023

I have read the CLA Document and I hereby sign the CLA

@KrAbhas
Copy link
Contributor Author

KrAbhas commented Jul 4, 2023

recheck

@marcochavezf marcochavezf requested review from MonilBhavsar and removed request for marcochavezf July 4, 2023 18:20
@marcochavezf
Copy link
Contributor

Assigning @MonilBhavsar here, since he was assigned from the original issue #16312

@KrAbhas
Copy link
Contributor Author

KrAbhas commented Jul 4, 2023

recheck

@KrAbhas
Copy link
Contributor Author

KrAbhas commented Jul 5, 2023 •
edited
Loading

⚠️ Important ⚠️
There are certain unverified commits, to avoid this I have raised a new PR, here is the link. This new PR has exactly same changes as in this PR. It has been created to save time.

@KrAbhas KrAbhas mentioned this pull request Jul 5, 2023
Merged
57 tasks
@MonilBhavsar MonilBhavsar requested a review from mollfpr July 5, 2023 05:29
@MonilBhavsar
Copy link
Contributor

@mollfpr looks like this PR is ready for a review. Could you please take a look

@Li357
Copy link
Contributor

Li357 commented Jul 5, 2023

@MonilBhavsar @mollfpr Can I assign you both to #22243, continue there and close this one out due to the unverified commits?

@MonilBhavsar
Copy link
Contributor

Yes please

@KrAbhas
Copy link
Contributor Author

KrAbhas commented Jul 5, 2023

⚠️ Important ⚠️
Closing this PR as this has unverified commits and new one is already being reviewed. For more details please refer these comments: comment1 and comment2

@KrAbhas KrAbhas closed this Jul 5, 2023
@KrAbhas KrAbhas deleted the migrating-workspaceReimburseView branch July 19, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

@mollfpr mollfpr Awaiting requested review from mollfpr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KrAbhas @marcochavezf @MonilBhavsar @Li357 @abhasadsk