Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Migrate WorkspaceReimburseView.js to function component #16312

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 51 comments
Closed
1 task

[$250] Migrate WorkspaceReimburseView.js to function component #16312

marcaaron opened this issue Mar 20, 2023 · 51 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017cf503cd0131d957
  • Upwork Job ID: 1673399792410345472
  • Last Price Increase: 2023-06-26
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate WorkspaceReimburseView.js to function component [HOLD] [$250] Migrate WorkspaceReimburseView.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@muxriddinmuqimov77
Copy link

I can work on this if goes to external

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

📣 @muxriddinmuqimov77! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@muxriddinmuqimov77
Copy link

Contributor details
Your Expensify account email: muxriddinmuqimov007@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01d01aef4263378596

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@s-alves10
Copy link
Contributor

I'd love to work on this.
I've a lot of experience in writing function components.

@marcaaron marcaaron changed the title [HOLD] [$250] Migrate WorkspaceReimburseView.js to function component [$250] Migrate WorkspaceReimburseView.js to function component Jun 26, 2023
@marcaaron marcaaron added NewFeature Something to build that is a new item. Daily KSv2 labels Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jun 26, 2023
@marcaaron marcaaron added External Added to denote the issue can be worked on by a contributor and removed Weekly KSv2 labels Jun 26, 2023
@melvin-bot melvin-bot bot removed the Daily KSv2 label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Job added to Upwork: https://www.upwork.com/jobs/~017cf503cd0131d957

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@mollfpr
Copy link
Contributor

mollfpr commented Jun 28, 2023

@kevinksullivan just checking again that @KrAbhas hasn't got assigned to any issue. We can let them take this one.

🎀 👀 🎀 C+ reviewed!

@melvin-bot
Copy link

melvin-bot bot commented Jun 28, 2023

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@kevinksullivan
Copy link
Contributor

Hi @KrAbhas can you apply for the job in upwork? Not sure if I am finding the right profile.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket :)

@KrAbhas
Copy link
Contributor

KrAbhas commented Jun 29, 2023

Hi @kevinksullivan, I have applied at upwork, you can find the proposal here

@mollfpr
Copy link
Contributor

mollfpr commented Jun 29, 2023

@MonilBhavsar @kevinksullivan let's assign this to @KrAbhas so they can start working on the PR 🚀

@code0406
Copy link
Contributor

I am eager to take on this task.

@MonilBhavsar
Copy link
Contributor

Do we need a proposal for refactor?

@0xmiros
Copy link
Contributor

0xmiros commented Jun 30, 2023

No need proposal but first commenter who isn't working on any migration issue right now, at the time of assign.
I can help who to assign 🙂

muxriddinmuqimov77 - 16310
s-alves10 - no migration issues but working on other 4 normal issues
neonbhai - 16215
rayane-djouah - 16270
KrAbhas - no issue assigned
olexyt - 16308
dayana7204 - 16273
asadath1395 - no issue assigned
code0406 - no issue assigned

Based on this, I recommend @KrAbhas as @mollfpr approved here.
cc: @MonilBhavsar

@vdem0115
Copy link

I would like to work on this issue.

@kevinksullivan
Copy link
Contributor

Hired @KrAbhas

@kevinksullivan kevinksullivan removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 30, 2023
@mollfpr
Copy link
Contributor

mollfpr commented Jul 1, 2023

@kevinksullivan Let's assign this issue to @KrAbhas

@KrAbhas Let me know when the PR is ready, thanks!

@melvin-bot
Copy link

melvin-bot bot commented Jul 3, 2023

📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account 🎉

Reviewer - [$250] Migrate WorkspaceReimburseView.js to function component

@melvin-bot
Copy link

melvin-bot bot commented Jul 3, 2023

📣 @KrAbhas 🎉 An offer has been automatically sent to your Upwork account 🎉

Contributor - [$250] Migrate WorkspaceReimburseView.js to function component Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@MonilBhavsar
Copy link
Contributor

@kevinksullivan I assigned @KrAbhas to the issue as per the process and above actions were triggered automatically. Let's please ensure we don't send multiple contracts 🙏

@melvin-bot melvin-bot bot removed the Overdue label Jul 3, 2023
@MonilBhavsar
Copy link
Contributor

@KrAbhas Any idea when the PR will be ready for review?

@KrAbhas
Copy link
Contributor

KrAbhas commented Jul 3, 2023

Thanks @MonilBhavsar for the assignment, I will raise the PR within 24 hours.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

@kevinksullivan, @mollfpr, @MonilBhavsar, @KrAbhas Whoops! This issue is 2 days overdue. Let's get this updated quick!

@kevinksullivan
Copy link
Contributor

PR is still WIP.

@KrAbhas
Copy link
Contributor

KrAbhas commented Jul 17, 2023

Hey @kevinksullivan , @MonilBhavsar, this is just a friendly reminder for further processes.

@kevinksullivan
Copy link
Contributor

Paid out and ended contracts. Just FYI @KrAbhas it looks like we had two contracts for you, so I paid you on one contract and ended them both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests