[IOUDetailsModal] deprecate component and cleanup code #19199

Prince-Mendiratta · 2023-05-18T17:06:50Z

Details

With this PR, we are cleaning up code to remove the IOUDetailsModal.

Fixed Issues

$ #19167
PROPOSAL: #19167 (comment)

Tests

To test this, we already know that IOUDetailsModal is not accessible directly. To do so, we need to navigate to the URL /iou/details/reportID/iouID.

On Web/mWeb:

Login to ND as user A.
Request money from user B.
Navigate to the user B's chat. Copy the chat ID from the URL.
Click on the IOU message to navigate to the IOU page. Copy the IOU ID from the URL.
Substitute the details and visit the URL /iou/details/reportID/iouID.
Ensure you are shown the Hmm.. It's not here page.

For an example, check out the attached video for Web.

It is not possible to test this on native & Desktop.

Another main thing this PR changes is that wherever the settlement button is present, if the user clicks on the option to settle with Bank Account and if they have not added a bank account, they will be redirected to the add bank account page depending on the IOU type. Follow these steps to test this functionality:

Login to ND as user A.
Request money from user B.
Login to ND as user B.
In the chat with user A, an IOU preview is shown. Click on it and choose bank account. Make sure user B does not have a bank account linked.
Ensure you are redirected to the add bank account page for personal bank. (Plaid flow will be initiated automatically).
Go to the IOU report for the money request. Click on the Settlement button in the header.
Ensure you are redirected to the add bank account page for personal bank.
Go to any workspace and request any amount.
In the workspace chat, an IOU preview is shown. Click on it and choose bank account. Make sure the workspace does not have a bank account linked.
Repeat steps 5-7 expect that this time, Ensure that you are redirected to the add bank account page for that workspace.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

2023-05-18.22-27-42.mp4

Mobile Web - Chrome

2023-05-18.22-30-39.mp4

Mobile Web - Safari

2023-05-18.22-33-41.mp4

Desktop

N/A

iOS

N/A

Android

N/A

melvin-bot · 2023-05-18T17:06:55Z

@luacmartins @0xmiroslav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Prince-Mendiratta · 2023-05-18T17:08:38Z

src/components/MoneyRequestHeader.js

@@ -153,7 +153,7 @@ const MoneyRequestHeader = (props) => {
                                    iouReport={props.report}
                                    onPress={(paymentType) => IOU.payMoneyRequest(paymentType, props.chatReport, props.report)}
                                    enablePaymentsRoute={ROUTES.BANK_ACCOUNT_NEW}
-                                    addBankAccountRoute={ROUTES.IOU_DETAILS_ADD_BANK_ACCOUNT}


@0xmiroslav I'm not familiar with the KYC Wall flow but theoretically, this should be good as it is used in the below mentioned place as well but I'd still appreciate if you could confirm it.

App/src/components/MoneyRequestConfirmationList.js

Line 291 in 5fab2de

addBankAccountRoute={ROUTES.IOU_SEND_ADD_BANK_ACCOUNT}

Can we use getBankAccountRoute instead? We should pass the policyID if this is an Expense report

@luacmartins why should we use getBankAccountRoute instead? Isn't addBankAccountRoute supposed to redirect to settings/payments/add-bank-account page? Does bank-account/${stepToOpen}?policyID=${policyID} automatically redirect to the add-bank-account page if none is linked?

So we have two conditions here:

IOU report: redirect to settings/payments/add-bank-account. Use SETTINGS_ADD_BANK_ACCOUNT route
Expense report: redirect to bank-account/new?policyID=${policyID}. Use this method

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

luacmartins

Looking good. Left a couple comments

src/ROUTES.js

luacmartins · 2023-05-19T15:31:18Z

src/components/MoneyRequestHeader.js

@@ -153,7 +153,7 @@ const MoneyRequestHeader = (props) => {
                                    iouReport={props.report}
                                    onPress={(paymentType) => IOU.payMoneyRequest(paymentType, props.chatReport, props.report)}
                                    enablePaymentsRoute={ROUTES.BANK_ACCOUNT_NEW}
-                                    addBankAccountRoute={ROUTES.IOU_DETAILS_ADD_BANK_ACCOUNT}


Can we use getBankAccountRoute instead? We should pass the policyID if this is an Expense report

src/components/ReportActionItem/IOUPreview.js

luacmartins · 2023-05-19T15:37:02Z

src/components/ReportActionItem/ReportPreview.js

@@ -142,7 +142,7 @@ const ReportPreview = (props) => {
                    iouReport={props.iouReport}
                    onPress={(paymentType) => IOU.payMoneyRequest(paymentType, props.chatReport, props.iouReport)}
                    enablePaymentsRoute={ROUTES.BANK_ACCOUNT_NEW}
-                    addBankAccountRoute={ROUTES.IOU_DETAILS_ADD_BANK_ACCOUNT}
+                    addBankAccountRoute={ROUTES.IOU_SEND_ADD_BANK_ACCOUNT}


Same here, let's use getBankAccountRoute and pass the policyID if this is a policyExpenseChat

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

0xmiros · 2023-05-22T11:01:23Z

@Prince-Mendiratta please fix conflict

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta · 2023-05-22T11:36:54Z

@0xmiroslav done!

src/components/MoneyRequestHeader.js

0xmiros · 2023-05-22T19:58:12Z

@Prince-Mendiratta let's do suggested changes and then all good.

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

0xmiros · 2023-05-23T14:26:09Z

@Prince-Mendiratta bump ^

Prince-Mendiratta · 2023-05-23T15:49:18Z

woops, I commited but it somehow wasn't pushed. Updated @0xmiroslav

src/components/ReportActionItem/ReportPreview.js

src/components/MoneyRequestHeader.js

luacmartins · 2023-05-23T18:19:44Z

src/components/MoneyRequestHeader.js

@@ -153,7 +153,7 @@ const MoneyRequestHeader = (props) => {
                                    iouReport={props.report}
                                    onPress={(paymentType) => IOU.payMoneyRequest(paymentType, props.chatReport, props.report)}
                                    enablePaymentsRoute={ROUTES.BANK_ACCOUNT_NEW}
-                                    addBankAccountRoute={ROUTES.IOU_DETAILS_ADD_BANK_ACCOUNT}


So we have two conditions here:

IOU report: redirect to settings/payments/add-bank-account. Use SETTINGS_ADD_BANK_ACCOUNT route
Expense report: redirect to bank-account/new?policyID=${policyID}. Use this method

src/components/ReportActionItem/ReportPreview.js

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

src/components/MoneyRequestConfirmationList.js

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta · 2023-05-23T19:40:27Z

@0xmiroslav @luacmartins updated the code and tests accordingly, please check it out! Here is the expected results.

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

0xmiros · 2023-05-23T21:43:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web1.mov

web2.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

web-ios.mov

Android

android.mov

0xmiros

LGTM!
@luacmartins all yours!

OSBotify · 2023-05-23T22:14:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-25T00:34:33Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T01:08:05Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T01:30:01Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-26T07:07:13Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.18-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Prince-Mendiratta requested a review from a team as a code owner May 18, 2023 17:06

melvin-bot bot requested review from 0xmiros and luacmartins and removed request for a team May 18, 2023 17:06

Prince-Mendiratta commented May 18, 2023

View reviewed changes

Prince-Mendiratta mentioned this pull request May 18, 2023

[HOLD for payment 2023-06-02] [$1000] Remove IOUDetailsModal component #19167

Closed

feat: deprecate IOUDetailsModal

8c56957

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

luacmartins requested changes May 19, 2023

View reviewed changes

feat: remove isIOUAction prop

943bf05

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

chore: merge conflicts

d5f654a

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

This comment was marked as resolved.

Sign in to view

0xmiros reviewed May 22, 2023

View reviewed changes

src/components/MoneyRequestHeader.js Outdated Show resolved Hide resolved

0xmiros reviewed May 22, 2023

View reviewed changes

src/components/MoneyRequestHeader.js Outdated Show resolved Hide resolved

feat: use getBankAccountRoute

b903bc9

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

0xmiros reviewed May 23, 2023

View reviewed changes

src/components/ReportActionItem/ReportPreview.js Outdated Show resolved Hide resolved

0xmiros reviewed May 23, 2023

View reviewed changes

src/components/MoneyRequestHeader.js Outdated Show resolved Hide resolved

luacmartins requested changes May 23, 2023

View reviewed changes

feat: expense report then workspace bank else personal

ad1542b

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

0xmiros reviewed May 23, 2023

View reviewed changes

src/components/MoneyRequestConfirmationList.js Outdated Show resolved Hide resolved

Prince-Mendiratta added 2 commits May 24, 2023 00:37

chore: merge conflicts

20627ea

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

feat: move duplicate code to function

fe5d34a

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

chore: prettier

9426102

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

0xmiros approved these changes May 23, 2023

View reviewed changes

luacmartins approved these changes May 23, 2023

View reviewed changes

luacmartins merged commit 3d7dce0 into Expensify:main May 23, 2023

OSBotify mentioned this pull request May 25, 2023

Deploy Checklist: New Expensify 2023-05-25 #19565

Closed

53 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IOUDetailsModal] deprecate component and cleanup code #19199

[IOUDetailsModal] deprecate component and cleanup code #19199

Prince-Mendiratta commented May 18, 2023 •

edited

Loading

melvin-bot bot commented May 18, 2023

Prince-Mendiratta May 18, 2023

luacmartins May 19, 2023

Prince-Mendiratta May 20, 2023

luacmartins May 23, 2023

luacmartins left a comment

luacmartins May 19, 2023

luacmartins May 19, 2023

0xmiros commented May 22, 2023

Prince-Mendiratta commented May 22, 2023

This comment was marked as resolved.

0xmiros commented May 22, 2023

0xmiros commented May 23, 2023

Prince-Mendiratta commented May 23, 2023

luacmartins May 23, 2023

Prince-Mendiratta commented May 23, 2023 •

edited

Loading

0xmiros commented May 23, 2023

0xmiros left a comment

OSBotify commented May 23, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 26, 2023

[IOUDetailsModal] deprecate component and cleanup code #19199

[IOUDetailsModal] deprecate component and cleanup code #19199

Conversation

Prince-Mendiratta commented May 18, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 18, 2023

Prince-Mendiratta May 18, 2023

Choose a reason for hiding this comment

luacmartins May 19, 2023

Choose a reason for hiding this comment

Prince-Mendiratta May 20, 2023

Choose a reason for hiding this comment

luacmartins May 23, 2023

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins May 19, 2023

Choose a reason for hiding this comment

luacmartins May 19, 2023

Choose a reason for hiding this comment

0xmiros commented May 22, 2023

Prince-Mendiratta commented May 22, 2023

This comment was marked as resolved.

0xmiros commented May 22, 2023

0xmiros commented May 23, 2023

Prince-Mendiratta commented May 23, 2023

luacmartins May 23, 2023

Choose a reason for hiding this comment

Prince-Mendiratta commented May 23, 2023 • edited Loading

0xmiros commented May 23, 2023

Reviewer Checklist

Screenshots/Videos

0xmiros left a comment

Choose a reason for hiding this comment

OSBotify commented May 23, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 26, 2023

Prince-Mendiratta commented May 18, 2023 •

edited

Loading

Prince-Mendiratta commented May 23, 2023 •

edited

Loading