Add errors object back to menu item, remove unused isPolicy #12460

roryabraham · 2022-11-04T02:00:09Z

Details

I'm not sure why this key was removed, I'm not sure it was done intentionally, cc @Justicea83

Also, I removed the unused isPolicy field. Its only usage was removed here. You can confirm by running the following from the App directory

ag 'isPolicy(?!ExpenseChat)'

That just finds all the occurrences of isPolicy not followed by ExpenseChat, and you can see there's only one such occurrence and it's unrelated:

Fixed Issues

$ #12452

Tests

Go to here, comment out the function contents and replace it with:

throw new ExpError('9A051C09-AD6C-44A2-B7BC-8F3B486DBCC3', 'You cannot delete this policy because it is set as the domain restricted one for a domain security group.', 'Cannot delete this policy');

Sign into an account on NewDot and make a workspace.
Go offline.
Go to Settings -> Workspaces -> <your_workspace> -> ... -> Delete Workspace to delete the workspace.
Verify that the workspace now appears with strikethrough. On web and desktop, hovering over the deleted workspace, your mouse style should change to disabled. On all platforms you should no longer be able to click into the workspace.
Go back to the home page.
Come back online.
Verify that there is a red dot over the settings menu icon.
Open the settings page.
Verify that there is a red dot over the Workspaces menu item
Click on the Workspaces menu item
Verify that there is a red dot over your individual workspace, and that there is an error message with an x next to it displaying beneath it.
Click on the x to dismiss the error message.
Verify that you can now click into the workspace again.

Verify that no errors appear in the JS console

QA Steps

Sign into "an account with the correct setup" applausetester@applause.expensifail.com
Perform the test steps above ^.

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

github-actions · 2022-11-04T02:00:32Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

roryabraham · 2022-11-04T02:03:19Z

Also repeated the testing steps from #12117 to verify that this PR doesn't break it, and it works fine:

roryabraham · 2022-11-04T02:03:42Z

Removing @Santhosh-Sellavel because the only way I know how to test this involves changing API layer code

luacmartins

LGTM and tests well! Thanks for the fix!

luacmartins · 2022-11-04T02:32:58Z

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

grgia · 2022-11-04T02:33:25Z

Tested well!

grgia

lgtm too!

melvin-bot · 2022-11-04T02:36:17Z

@luacmartins looks like this was merged without the Run e2e performance regression tests test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2022-11-04T02:37:10Z

Tests passed. Removing Emergency label.

Add errors object back to menu item, remove unused isPolicy (cherry picked from commit e275d4f)

…-12460 🍒 Cherry pick PR #12460 to staging 🍒

OSBotify · 2022-11-04T03:48:50Z

🚀 Cherry-picked to staging by @luacmartins in version: 1.2.23-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Justicea83 · 2022-11-04T11:00:27Z

We had a discussion on this to only show the error message on the policy details page.(https://expensify.slack.com/archives/C01GTK53T8Q/p1666955764560879)

Justicea83 · 2022-11-04T11:44:19Z

Tests well on IOS staging.

Justicea83 · 2022-11-04T11:49:51Z

Web Tests well

Julesssss · 2022-11-04T11:51:44Z

Verified Android mWeb and App

mWeb

Android

Justicea83 · 2022-11-04T11:59:04Z

Desktop

Julesssss · 2022-11-04T12:00:09Z

Cool, thanks @Justicea83 -- checking this one off.

OSBotify · 2022-11-04T17:10:56Z

🚀 Deployed to production by @Julesssss in version: 1.2.23-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:42:16Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T19:00:01Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add errors object back, remove unused isPolicy

5e28cbc

roryabraham added the CP Staging label Nov 4, 2022

roryabraham requested a review from a team as a code owner November 4, 2022 02:00

roryabraham self-assigned this Nov 4, 2022

melvin-bot bot requested review from Santhosh-Sellavel and thienlnam and removed request for a team November 4, 2022 02:00

roryabraham removed the request for review from Santhosh-Sellavel November 4, 2022 02:03

roryabraham mentioned this pull request Nov 4, 2022

Workspace - User does not see the "error message" when deleting a workspace #12452

Closed

luacmartins approved these changes Nov 4, 2022

View reviewed changes

grgia self-requested a review November 4, 2022 02:34

grgia approved these changes Nov 4, 2022

View reviewed changes

luacmartins merged commit e275d4f into main Nov 4, 2022

luacmartins deleted the Rory-FixWorkspaceRBR branch November 4, 2022 02:36

melvin-bot bot added the Emergency label Nov 4, 2022

luacmartins removed the Emergency label Nov 4, 2022

OSBotify pushed a commit that referenced this pull request Nov 4, 2022

Merge pull request #12460 from Expensify/Rory-FixWorkspaceRBR

3b14846

Add errors object back to menu item, remove unused isPolicy (cherry picked from commit e275d4f)

OSBotify mentioned this pull request Nov 4, 2022

🍒 Cherry pick PR #12460 to staging 🍒 #12462

Merged

OSBotify added a commit that referenced this pull request Nov 4, 2022

Merge pull request #12462 from Expensify/OSBotify-cherry-pick-staging…

49e2d30

…-12460 🍒 Cherry pick PR #12460 to staging 🍒

OSBotify mentioned this pull request Nov 4, 2022

Deploy Checklist: New Expensify 2022-11-02 #12397

Closed

44 tasks

OSBotify mentioned this pull request Nov 4, 2022

Deploy Checklist: New Expensify 2022-11-04 #12476

Closed

20 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add errors object back to menu item, remove unused isPolicy #12460

Add errors object back to menu item, remove unused isPolicy #12460

roryabraham commented Nov 4, 2022

github-actions bot commented Nov 4, 2022

roryabraham commented Nov 4, 2022

roryabraham commented Nov 4, 2022

luacmartins left a comment

luacmartins commented Nov 4, 2022

grgia commented Nov 4, 2022

grgia left a comment

melvin-bot bot commented Nov 4, 2022

luacmartins commented Nov 4, 2022

OSBotify commented Nov 4, 2022

Justicea83 commented Nov 4, 2022

Justicea83 commented Nov 4, 2022

Justicea83 commented Nov 4, 2022

Julesssss commented Nov 4, 2022

Justicea83 commented Nov 4, 2022

Julesssss commented Nov 4, 2022

OSBotify commented Nov 4, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Add errors object back to menu item, remove unused isPolicy #12460

Add errors object back to menu item, remove unused isPolicy #12460

Conversation

roryabraham commented Nov 4, 2022

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

github-actions bot commented Nov 4, 2022

roryabraham commented Nov 4, 2022

roryabraham commented Nov 4, 2022

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Nov 4, 2022

grgia commented Nov 4, 2022

grgia left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 4, 2022

luacmartins commented Nov 4, 2022

OSBotify commented Nov 4, 2022

Justicea83 commented Nov 4, 2022

Justicea83 commented Nov 4, 2022

Justicea83 commented Nov 4, 2022

Julesssss commented Nov 4, 2022

Verified Android mWeb and App

Justicea83 commented Nov 4, 2022

Julesssss commented Nov 4, 2022

OSBotify commented Nov 4, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023