Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - User does not see the "error message" when deleting a workspace #12452

Closed
kbecciv opened this issue Nov 3, 2022 · 9 comments
Closed
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Nov 3, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the New expensify app
  2. Sign into an account with the correct set up applausetester@applause.expensifail.com
  3. Navigate to Settings
  4. Disable the internet connection in the device
  5. Tap on the 3 dots and select "Delete Workspace"
  6. Confirm the modal to delete the workspace
  7. Verify the workspace is now displayed with a strikethrough indicating it will be deleted when back online
  8. Enable the internet connection in the device
  9. Wait a few seconds for the app to update
  10. Close the settings modal

Expected Result:

The user expects to see a red dot in the profile icon and display a message on the workspace with the error as "You cannot delete this workspace because it's set as the domain restricted one for a domain security group" that can be removed

Actual Result:

The user sees the red dot in the profile icon, however they can no longer see the deleted workspace after returning online and can not see the error message text.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.23.7

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5805000_User_does_not_see_the_error_message_after_returning_online_and_the_worksapce_is_also_gone.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 3, 2022
@kbecciv
Copy link
Author

kbecciv commented Nov 3, 2022

Issue is not reproduced in production

@OSBotify
Copy link
Contributor

OSBotify commented Nov 3, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Nov 3, 2022

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@roryabraham
Copy link
Contributor

Guessing it's something to do with this PR

@roryabraham
Copy link
Contributor

Going to snag this to see if we can get the deploy over the finish line today

@roryabraham roryabraham assigned roryabraham and unassigned tgolen Nov 4, 2022
@roryabraham
Copy link
Contributor

Sign into an account with the correct set up

@kbecciv This is pretty vague. What is the "correct setup"?

@roryabraham
Copy link
Contributor

Seems like a domain restricted policy is a requirement here, need to find out what that is...

@roryabraham
Copy link
Contributor

Okay, I was able to reproduce this locally (albeit with a hack in the API layer)

@roryabraham
Copy link
Contributor

Got a fix ready: #12460

@roryabraham roryabraham added the Reviewing Has a PR in review label Nov 4, 2022
@roryabraham roryabraham assigned Justicea83 and unassigned Justicea83 Nov 4, 2022
@melvin-bot melvin-bot bot closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants