Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2024-06-13] [Details Revamp] Update ProfilePage #42077

Closed
grgia opened this issue May 13, 2024 · 22 comments
Closed

[$250] [HOLD for payment 2024-06-13] [Details Revamp] Update ProfilePage #42077

grgia opened this issue May 13, 2024 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented May 13, 2024

https://docs.google.com/document/d/1-xSZdSZZIuIl0fPO7yypkKfcbWEsnNFAs50ptgL3Gnw/edit#bookmark=id.k681an84656p

Held on #42071

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01621b7ae67842d92a
  • Upwork Job ID: 1801131122718918182
  • Last Price Increase: 2024-06-13
Issue OwnerCurrent Issue Owner: @grgia
@grgia grgia added Daily KSv2 NewFeature Something to build that is a new item. labels May 13, 2024
@grgia grgia self-assigned this May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@grgia grgia changed the title [Details Revamp] Update ProfilePage [HOLD #42071][Details Revamp] Update ProfilePage May 13, 2024
@kosmydel
Copy link
Contributor

Hey, I'm from SWM and I will work on this.

@kosmydel kosmydel mentioned this issue May 15, 2024
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 20, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 3, 2024
@kosmydel
Copy link
Contributor

kosmydel commented Jun 3, 2024

The PR is actively in review. The code was accepted, and we are waiting for a review from the design team.

@trjExpensify trjExpensify changed the title [HOLD #42071][Details Revamp] Update ProfilePage [Details Revamp] Update ProfilePage Jun 3, 2024
Copy link

melvin-bot bot commented Jun 5, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 6, 2024
@melvin-bot melvin-bot bot changed the title [Details Revamp] Update ProfilePage [HOLD for payment 2024-06-13] [Details Revamp] Update ProfilePage Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-13. 🎊

Copy link

melvin-bot bot commented Jun 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@grgia] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@akinwale
Copy link
Contributor

@kadiealexander Please assign me as the C+ here since I reviewed the PR. Thanks.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 12, 2024
@kadiealexander kadiealexander added the External Added to denote the issue can be worked on by a contributor label Jun 13, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-13] [Details Revamp] Update ProfilePage [$250] [HOLD for payment 2024-06-13] [Details Revamp] Update ProfilePage Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01621b7ae67842d92a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Current assignee @akinwale is eligible for the External assigner, not assigning anyone new.

@kadiealexander
Copy link
Contributor

kadiealexander commented Jun 13, 2024

Payouts due:

Upwork job is here.

@akinwale
Copy link
Contributor

@kadiealexander Upwork offer accepted. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jun 17, 2024
@kadiealexander
Copy link
Contributor

@grgia could you please share the regression test steps mentioned here?

@grgia
Copy link
Contributor Author

grgia commented Jun 18, 2024

@JmillsExpensify do you have regression steps written out somewhere already for this project?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 18, 2024
@grgia
Copy link
Contributor Author

grgia commented Jun 21, 2024

bump @JmillsExpensify

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 21, 2024
Copy link

melvin-bot bot commented Jun 24, 2024

@akinwale, @grgia, @kadiealexander, @dubielzyk-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@grgia
Copy link
Contributor Author

grgia commented Jun 25, 2024

Waiting on confirmation of regression steps from @JmillsExpensify

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 25, 2024
@grgia
Copy link
Contributor Author

grgia commented Jun 28, 2024

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2024
Copy link

melvin-bot bot commented Jul 1, 2024

@akinwale, @grgia, @kadiealexander, @dubielzyk-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@grgia
Copy link
Contributor Author

grgia commented Jul 2, 2024

I'm actually going to close this one as complete, since this is part of the details revamp project, the regression steps will be covered by the manual tests. cc @JmillsExpensify do you have a link to the manual tests for the doc?

@grgia grgia closed this as completed Jul 2, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

5 participants