Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-11] [Details Revamp] Update/Create PromotedActionsBar #42071

Closed
grgia opened this issue May 13, 2024 · 18 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented May 13, 2024

https://docs.google.com/document/d/1-xSZdSZZIuIl0fPO7yypkKfcbWEsnNFAs50ptgL3Gnw/edit#bookmark=id.blbc2di8aqdp

  • Add component to storybook
Issue OwnerCurrent Issue Owner: @dylanexpensify
@grgia grgia added Daily KSv2 NewFeature Something to build that is a new item. labels May 13, 2024
@grgia grgia self-assigned this May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@kosmydel
Copy link
Contributor

Hey, I'm Jakub from SWM. I will work on this.

@dylanexpensify
Copy link
Contributor

Fantastic! Thanks @kosmydel!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 14, 2024
@dylanexpensify
Copy link
Contributor

Ongoing! @kosmydel mind giving an ETA?

@kosmydel
Copy link
Contributor

Ongoing! @kosmydel mind giving an ETA?

This one got approval yesterday from both C+ and internal :) Today I made one minor adjustment. It is waiting for the merge freeze to end.

@dylanexpensify
Copy link
Contributor

merge freeze ending for all but Auth!

@kosmydel
Copy link
Contributor

kosmydel commented Jun 3, 2024

The PR solving this issue got merged last week :)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 4, 2024
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Jun 4, 2024
@melvin-bot melvin-bot bot changed the title [Details Revamp] Update/Create PromotedActionsBar [HOLD for payment 2024-06-11] [Details Revamp] Update/Create PromotedActionsBar Jun 4, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jun 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

  • @kosmydel does not require payment (Contractor)

Copy link

melvin-bot bot commented Jun 4, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@kosmydel] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@dylanexpensify
Copy link
Contributor

coming up!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 10, 2024
@dylanexpensify
Copy link
Contributor

No payment needed

@rojiphil
Copy link
Contributor

rojiphil commented Jun 13, 2024

No payment needed

@dylanexpensify Oh sorry. This just slipped out of my radar.
Please note I was C+ here and is due payment. Reviewer checklist and this.

@dylanexpensify
Copy link
Contributor

Ah @rojiphil, thanks for ping, please apply here!

@rojiphil
Copy link
Contributor

Ah @rojiphil, thanks for ping, please apply here!

Thanks @dylanexpensify. Applied to the upwork job.

@dylanexpensify
Copy link
Contributor

Done! Thanks @rojiphil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

5 participants