[HOLD for payment 2024-03-25] Profile avatar is not aligned within highlighted circle

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition: Device font size is minimum.

1. Launch New Expensify app.
2. Go to Profile.

Expected Result:

Profile avatar is aligned within highlighted circle

Actual Result:

Profile avatar is not aligned within highlighted circle
Reproducible in SG Note 10+ / Android 12 , SG Z Fold 4 / Android 14,iPhone 15 Pro Max / iOS 17.3.1

Workaround:

visual

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016e3c16578ce4b6d1
• Upwork Job ID: 1768105574093357056
• Last Price Increase: 2024-03-14

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[robertjchen]

Not a deploy blocker. Opening for External Contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016e3c16578ce4b6d1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Upwork job price has been updated to $125

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile avatar is not aligned within highlighted circle
Reproducible in SG Note 10+ / Android 12 , SG Z Fold 4 / Android 14,iPhone 15 Pro Max / iOS 17.3.1

What is the root cause of that problem?

Here we're using dynamic width and height based on componentSizeSmall which will change depending on the font size as can be seen here. Meanwhile both the borderRadius here and the size of the Avatar here are both 28, so in small font size, the container of the Avatar has size less than 28, leading to the broken UI.

What changes do you think we should make in order to solve the problem?

As far as I know the avatar size is always static (based on the avatar size we assigned to it). So it doesn't make sense for the container View of that avatar to have dynamic size based on font size

To fix it, in here, simply Use both width and height as 28

What alternative solutions did you explore? (Optional)

Make both the borderRadius and Avatar size to be dynamic based on font-size same as the container here

[kosmydel]

Hey, I'm from Software Mansion. I will work on this.

[mkhutornyi]

Please assign me here too since I reported this earlier while reviewing PR and also have android device I can reproduce this bug on.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Ideal Nav v2] Fix avatar alignment and bottom gap #38274

If no regressions arise, payment will be issued on 2024-03-25. 🎊

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment (Needs manual offer from BZ)
• @kosmydel does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
• [@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mkhutornyi] Determine if we should create a regression test for this bug.
• [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kosmydel]

This one is related to #38463.

[twisterdotcom]

Payment Summary:

• @mkhutornyi paid $125 here (C+)
• @kosmydel does not require payment (Contractor) (Contributor)