[$500] [HOLD for payment 2024-04-03] IOS - Profile - Avatar loading icon is not aligned properly within the highlighted green circle

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.53-2
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Device font is minimum.

1. Launch New Expensify app.
2. Log in.
3. While the app is in skeleton loading state, tap on Profile icon.

Expected Result:

The avatar loading icon has the correct size within the highlighted green circle.

Actual Result:

The avatar loading icon is small and not aligned properly within the highlighted green circle.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0183d1c8e91b21dfe4
• Upwork Job ID: 1775220315708272640
• Last Price Increase: 2024-04-02

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[mkhutornyi]

Maybe @kosmydel can take a look

[apeyada]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - Profile - Avatar loading icon is not aligned properly within the highlighted green circle

What is the root cause of that problem?

avatar skeleton size isn't consistent with parent view size

App/src/styles/index.ts

Lines 1445 to 1449 in c915e7f

	sidebarAvatar: {
	borderRadius: 28,
	height: 28,
	width: 28,
	},

App/src/components/AvatarSkeleton.tsx

Lines 12 to 22 in c915e7f

	<SkeletonViewContentLoader
	animate
	height={variables.componentSizeSmall}
	backgroundColor={theme.skeletonLHNIn}
	foregroundColor={theme.skeletonLHNOut}
	>
	<Circle
	cx={skeletonCircleRadius}
	cy={skeletonCircleRadius}
	r={skeletonCircleRadius}
	/>

What changes do you think we should make in order to solve the problem?

App/src/components/AvatarSkeleton.tsx

Lines 12 to 14 in c915e7f

	<SkeletonViewContentLoader
	animate
	height={variables.componentSizeSmall}

Update this height to 28
Also update circle sizes to 14:

App/src/components/AvatarSkeleton.tsx

Lines 18 to 22 in c915e7f

	<Circle
	cx={skeletonCircleRadius}
	cy={skeletonCircleRadius}
	r={skeletonCircleRadius}
	/>

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile - Avatar loading icon is not aligned properly within the highlighted green circle.

What is the root cause of that problem?

AvatarSkeleton uses componentSizeSmall as height.

App/src/components/AvatarSkeleton.tsx

Lines 12 to 23 in c915e7f

	<SkeletonViewContentLoader
	animate
	height={variables.componentSizeSmall}
	backgroundColor={theme.skeletonLHNIn}
	foregroundColor={theme.skeletonLHNOut}
	>
	<Circle
	cx={skeletonCircleRadius}
	cy={skeletonCircleRadius}
	r={skeletonCircleRadius}
	/>
	</SkeletonViewContentLoader>

componentSizeSmall is dependent on the font size since it uses getValueUsingPixelRatio.

App/src/styles/variables.ts

Line 18 in c915e7f

componentSizeSmall: getValueUsingPixelRatio(28, 32),

What changes do you think we should make in order to solve the problem?

Use 28 size directly without getValueUsingPixelRatio to make the icon independent of font size, just like the chats bubble icon in the bottom bar is also independent of the font size.

<SkeletonViewContentLoader
    animate
-  height={variables.componentSizeSmall}
+  height={variables.avatarSizeSmall}
    backgroundColor={theme.skeletonLHNIn}
    foregroundColor={theme.skeletonLHNOut}
>

What alternative solutions did you explore? (Optional)

Alternatively, we can ensure that the border circle radius/size becomes dependent on the font size, then both the avatar and circle will scale together.

[abzokhattab]

might be a duplicate of #38263

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

This does seem like could have been resolved by #38274 which we wont CP, removing the blocker label.

Lets retest in next staging release @kavimuru @kbecciv

[kosmydel]

This does seem like could have been resolved by #38274 which we wont CP, removing the blocker label.

Lets retest in next staging release @kavimuru @kbecciv

I will check it later today if the issue still occurs.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.56-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Extract sidebarAvatarSize to variable #38463

If no regressions arise, payment will be issued on 2024-04-03. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
• [@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hayata-suenaga] Determine if we should create a regression test for this bug.
• [@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

Assigned to @mkhutornyi since you were the C+ reviewer on the PR.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0183d1c8e91b21dfe4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[lschurr]

Sorry for the ping @ikevin127 - This bug is already fixed. Removing your assignment :)

[lschurr]

Payment summary:

• Contributor: @kosmydel (agency, no payment needed)
• Contributor+: @mkhutornyi $500 (Offer sent in Upwork)

[lschurr]

Hi @mkhutornyi - please accept the offer in Upwork :)

[lschurr]

Bumped in Slack

[lschurr]

Still waiting for @mkhutornyi to accept the offer. Moving to Weekly in the meantime.

[lschurr]

The offer still isn't accepted by @mkhutornyi - I've reached out in Slack. Please reopen the GH or send me a message via Slack when you're ready for payment. Closing this GH for now.

[lschurr]

New offer sent to @mkhutornyi - https://www.upwork.com/nx/wm/offer/102626632