Dev: Web - Incorrect Screen when Clicking CMD+K while Year Selection Modal is opened. #27160

kbecciv · 2023-09-11T15:16:55Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open profile, then open personal details
Open DOB, Select the year
Press CMD+K

Expected Result:

Search page should open

Actual Result:

YearModal is on top of searchmodal, closing year modal open Search page which is incorrect.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number:
Reproducible in staging?: Yes, v1.3.67-3
Reproducible in production?: Yes, v1.3.66-3
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-11.at.8.19.24.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694443603230179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a5b8a53241ab3b2d
Upwork Job ID: 1711342041166319616
Last Price Increase: 2023-10-09

OSBotify · 2023-09-11T15:17:47Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-09-11T15:17:51Z

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

roryabraham · 2023-09-11T16:18:44Z

@arosiclair I found a solution to this one

roryabraham · 2023-09-11T16:58:51Z

Confirmed that this was not caused by #26346

roryabraham · 2023-09-11T16:59:53Z

Quick summary of my solution to this problem:

The NewDatePicker always uses push-to-page for the year selection
The YearPickerModal is not a react-navigation screen – it's just a Modal. However, in order for the browser back button and keyboard navigation to work correctly, we can't really use a plain Modal component.
So in order to make the NewDatePicker work, we need to provide the route we want it to open for the year picker.

So the changes I'll make are:

Refactor YearPickerModal so that it's not a modal, just a YearPicker
Create a new route at settings/profile/personal-details/date-of-birth/year, and a corresponding screen in the SettingsModalNavigator. It will take in the props for the YearPicker via its route.params
Then update NewDatePicker to accept a prop for the yearPickerRoute. Instead of rendering the YearPickerModal it will just navigate to the route provided by yearPickerRoute and inject the correct props into the route params

roryabraham · 2023-09-11T17:21:48Z

Slack context: https://expensify.slack.com/archives/C07J32337/p1694450478955679

ishpaul777 · 2023-09-11T17:32:06Z

the same issue is reproduceable for StatePickerModal. @roryabraham

Screen.Recording.2023-09-11.at.10.59.38.PM.mov

arosiclair · 2023-09-11T19:24:36Z

Reproduced on prod v1.3.66-3 so not a blocker. Also repro'd on staging v1.3.67-3

Screen.Recording.2023-09-11.at.3.20.33.PM.mov

arosiclair · 2023-09-11T19:28:45Z

I'm not seeing any existing issues for this so getting BZ on this

melvin-bot · 2023-09-11T19:28:57Z

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-11T19:28:59Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

ishpaul777 · 2023-09-11T19:31:21Z

@arosiclair in prod and staging the keyboard shortcuts working but on dev main the YearPicker modal not closing and is on top on search page, when cmd+k pressed for search navigation

michaelhaxhiu · 2023-09-28T13:57:25Z

(wowa sorry about the multiple assignments - melvin puked. Gonna leave this with Isa for ease! This is real close to completion)

arosiclair · 2023-10-02T07:38:23Z

Confirmed reverting #27639 re-introduces the issue 👍 @isabelastisser

melvin-bot · 2023-10-02T10:50:20Z

@arosiclair @isabelastisser this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

isabelastisser · 2023-10-02T18:08:30Z

hey @arosiclair, what does it mean? 😬 What are the next steps here? Is all we need to do pay @ishpaul777 #27160 (comment)? If yes, the new bug report amount?

arosiclair · 2023-10-03T08:57:35Z

Is all we need to do pay @ishpaul777 #27160 (comment)? If yes, the new bug report amount?

Yes exactly. Bug report payment for @ishpaul777 would be $50 per this comment

melvin-bot · 2023-10-06T11:21:48Z

@arosiclair, @isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

arosiclair · 2023-10-09T08:49:54Z

Looks like @isabelastisser is now OOO 🙃. Re-applying Bug so we can finally get this closed out

melvin-bot · 2023-10-09T08:50:19Z

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-09T08:50:21Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-09T11:25:08Z

@arosiclair @peterdbarkerUK this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

melvin-bot · 2023-10-09T11:25:14Z

Job added to Upwork: https://www.upwork.com/jobs/~01a5b8a53241ab3b2d

melvin-bot · 2023-10-09T11:25:19Z

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

peterdbarkerUK · 2023-10-10T14:31:15Z

Offer sent @ishpaul777 :)

$50 to @ishpaul777 for bug report

ishpaul777 · 2023-10-10T14:34:38Z

Thank you @peterdbarkerUK accepted the offer!

0xmiros · 2023-10-12T17:07:14Z

Can we fix this bug here? #27639 which closed this GH caused this bad regression.
The regression period is over so we can't request original PR author/reviewer to fix this.

Repro step:

Open FAB menu and then close
Press Cmd+K
Expects to open Search page but nothing happens (BUG)
Open FAB menu again and then close
Search page automatically opens this time (another BUG)

Screen.Recording.2023-10-12.at.7.03.11.PM.mov

This is also blocking #28249

cc: @AndrewGable

pradeepmdk · 2023-10-12T17:20:11Z

Can we fix this bug here? #27639 which closed this GH caused this bad regression. The regression period is over so we can't request original PR author/reviewer to fix this.

Repro step:

Open FAB menu and then close

Press Cmd+K

Expects to open Search page but nothing happens (BUG)

Open FAB menu again and then close

Search page automatically opens this time (another BUG)

Screen.Recording.2023-10-12.at.7.03.11.PM.mov
This is also blocking #28249

cc: @AndrewGable

@0xmiroslav i think this is different bug #29341

pradeepmdk · 2023-10-12T17:23:44Z

and this bug from this PR https://github.com/Expensify/App/pull/29251/files they forgot to close the modal on cleanup function

kbecciv added DeployBlockerCash This issue or pull request should block deployment Needs Reproduction Reproducible steps needed labels Sep 11, 2023

OSBotify mentioned this issue Sep 11, 2023

Deploy Checklist: New Expensify 2023-09-11 #27120

Closed

31 tasks

github-actions bot added Engineering Hourly KSv2 labels Sep 11, 2023

melvin-bot bot assigned arosiclair Sep 11, 2023

roryabraham self-assigned this Sep 11, 2023

arosiclair removed their assignment Sep 11, 2023

melvin-bot bot mentioned this issue Sep 11, 2023

[HOLD for payment 2023-09-20] [$1000] Web - Profile - No back button on personal details offline mode #24642

Closed

6 tasks

roryabraham assigned arosiclair and unassigned roryabraham Sep 11, 2023

arosiclair added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 Needs Reproduction Reproducible steps needed labels Sep 11, 2023

arosiclair added Bug Something is broken. Auto assigns a BugZero manager. and removed Engineering labels Sep 11, 2023

melvin-bot bot assigned michaelhaxhiu Sep 11, 2023

Expensify deleted a comment from melvin-bot bot Sep 28, 2023

melvin-bot bot added the Engineering label Oct 2, 2023

melvin-bot bot added the Overdue label Oct 5, 2023

melvin-bot bot removed the Overdue label Oct 9, 2023

arosiclair unassigned isabelastisser Oct 9, 2023

arosiclair added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 9, 2023

melvin-bot bot assigned peterdbarkerUK Oct 9, 2023

melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Oct 9, 2023

melvin-bot bot assigned aimane-chnaif Oct 9, 2023

peterdbarkerUK closed this as completed Oct 10, 2023

0xmiros mentioned this issue Oct 12, 2023

[HOLD for payment 2023-11-02] [$500] Web - Room - Search list can be opened with CMD + K in public room as anonymous user #28249

Closed

6 tasks

aimane-chnaif mentioned this issue Dec 7, 2023

[HOLD for payment 2024-02-07] [$500] Search Page opens in Background when delete Reciept Confirm Modal is visible #29511

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev: Web - Incorrect Screen when Clicking CMD+K while Year Selection Modal is opened. #27160

Dev: Web - Incorrect Screen when Clicking CMD+K while Year Selection Modal is opened. #27160

kbecciv commented Sep 11, 2023 •

edited by melvin-bot bot

Loading

OSBotify commented Sep 11, 2023

melvin-bot bot commented Sep 11, 2023

roryabraham commented Sep 11, 2023

roryabraham commented Sep 11, 2023

roryabraham commented Sep 11, 2023

roryabraham commented Sep 11, 2023

ishpaul777 commented Sep 11, 2023 •

edited

Loading

arosiclair commented Sep 11, 2023

arosiclair commented Sep 11, 2023

melvin-bot bot commented Sep 11, 2023

melvin-bot bot commented Sep 11, 2023

ishpaul777 commented Sep 11, 2023 •

edited

Loading

michaelhaxhiu commented Sep 28, 2023

arosiclair commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

isabelastisser commented Oct 2, 2023

arosiclair commented Oct 3, 2023

melvin-bot bot commented Oct 6, 2023

arosiclair commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

peterdbarkerUK commented Oct 10, 2023 •

edited

Loading

ishpaul777 commented Oct 10, 2023

0xmiros commented Oct 12, 2023 •

edited

Loading

pradeepmdk commented Oct 12, 2023

pradeepmdk commented Oct 12, 2023 •

edited

Loading

Dev: Web - Incorrect Screen when Clicking CMD+K while Year Selection Modal is opened. #27160

Dev: Web - Incorrect Screen when Clicking CMD+K while Year Selection Modal is opened. #27160

Comments

kbecciv commented Sep 11, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

OSBotify commented Sep 11, 2023

melvin-bot bot commented Sep 11, 2023

roryabraham commented Sep 11, 2023

roryabraham commented Sep 11, 2023

roryabraham commented Sep 11, 2023

roryabraham commented Sep 11, 2023

ishpaul777 commented Sep 11, 2023 • edited Loading

arosiclair commented Sep 11, 2023

arosiclair commented Sep 11, 2023

melvin-bot bot commented Sep 11, 2023

melvin-bot bot commented Sep 11, 2023

Bug0 Triage Checklist (Main S/O)

ishpaul777 commented Sep 11, 2023 • edited Loading

michaelhaxhiu commented Sep 28, 2023

arosiclair commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

isabelastisser commented Oct 2, 2023

arosiclair commented Oct 3, 2023

melvin-bot bot commented Oct 6, 2023

arosiclair commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

peterdbarkerUK commented Oct 10, 2023 • edited Loading

ishpaul777 commented Oct 10, 2023

0xmiros commented Oct 12, 2023 • edited Loading

pradeepmdk commented Oct 12, 2023

pradeepmdk commented Oct 12, 2023 • edited Loading

kbecciv commented Sep 11, 2023 •

edited by melvin-bot bot

Loading

ishpaul777 commented Sep 11, 2023 •

edited

Loading

ishpaul777 commented Sep 11, 2023 •

edited

Loading

peterdbarkerUK commented Oct 10, 2023 •

edited

Loading

0xmiros commented Oct 12, 2023 •

edited

Loading

pradeepmdk commented Oct 12, 2023 •

edited

Loading